Merge ~hloeung/layer-snap:master into ~stub/layer-snap:master

Proposed by Haw Loeung
Status: Merged
Merged at revision: cdae90c9f5b0cf8f8a311cff2f189dbca4a9f00a
Proposed branch: ~hloeung/layer-snap:master
Merge into: ~stub/layer-snap:master
Diff against target: 19 lines (+0/-8)
1 file modified
reactive/snap.py (+0/-8)
Reviewer Review Type Date Requested Status
Stuart Bishop Approve
Review via email: mp+326207@code.launchpad.net

Description of the change

Overriding snapd proxy via /etc/systemd/system/snapd.service.d/* also works in Trusty - LP:1533899

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reactive/snap.py b/reactive/snap.py
2index b2ec73e..08974ae 100644
3--- a/reactive/snap.py
4+++ b/reactive/snap.py
5@@ -104,14 +104,6 @@ def update_snap_proxy():
6 # updates.
7 proxy = proxy_settings()
8
9- if get_series() == 'trusty':
10- # The hack to configure a snapd proxy only works under
11- # xenial or later.
12- if proxy:
13- hookenv.log('snap_proxy config is not supported under '
14- 'Ubuntu 14.04 (trusty)', hookenv.ERROR)
15- return
16-
17 path = '/etc/systemd/system/snapd.service.d/snap_layer_proxy.conf'
18 if not proxy and not os.path.exists(path):
19 return # No proxy asked for and proxy never configured.

Subscribers

People subscribed via source and target branches

to all changes: