Merge lp:~hloeung/launchpad/openpgp-show-fingerprint into lp:launchpad

Proposed by Haw Loeung on 2014-12-12
Status: Superseded
Proposed branch: lp:~hloeung/launchpad/openpgp-show-fingerprint
Merge into: lp:launchpad
Diff against target: 14 lines (+2/-1)
1 file modified
lib/lp/services/gpg/handler.py (+2/-1)
To merge this branch: bzr merge lp:~hloeung/launchpad/openpgp-show-fingerprint
Reviewer Review Type Date Requested Status
William Grant 2014-12-12 Needs Fixing on 2015-01-06
Review via email: mp+244614@code.launchpad.net

This proposal has been superseded by a proposal from 2015-06-24.

Description of the Change

Launchpad uses the key fingerprint for the initial search but from there, SKS defaults to using 0xlong (16-character key ID). This MP enables showing the key fingerprint as that's the SKS default; http://keyserver.ubuntu.com:11371/ has that enabled by default.

Current: http://keyserver.ubuntu.com:11371/pks/lookup?search=0x2C5CBE094DF8E590E57A8460B294FF6EFA5C7D29&op=index
With fingerprint: http://keyserver.ubuntu.com:11371/pks/lookup?search=0x2C5CBE094DF8E590E57A8460B294FF6EFA5C7D29&op=index&fingerprint=on

Also small OCD reordering of "op=index" as per web form.

To post a comment you must log in.
William Grant (wgrant) wrote :

This will probably break at least xx-person-rdf.txt, gpghandler.txt, xx-ubuntu-ppas.txt and test_web.py. Otherwise it looks sensible.

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/services/gpg/handler.py'
2--- lib/lp/services/gpg/handler.py 2014-03-11 03:30:54 +0000
3+++ lib/lp/services/gpg/handler.py 2014-12-12 22:40:33 +0000
4@@ -462,8 +462,9 @@
5 def getURLForKeyInServer(self, fingerprint, action='index', public=False):
6 """See IGPGHandler"""
7 params = {
8+ 'op': action,
9 'search': '0x%s' % fingerprint,
10- 'op': action,
11+ 'fingerprint': 'on',
12 }
13 if public:
14 host = config.gpghandler.public_host