lp:~hloeung/jenkins-agent-charm/reactive-rewrite

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:jenkins-agent-charm at revision 22

Tom Haddon: Approve on 2019-03-01

Haw Loeung: Needs Resubmitting on 2019-03-01

Canonical IS Reviewers: Pending requested 2019-02-26

Diff: 1152 lines (+673/-311)

25 files modified

.bzrignore (+11/-0)
Makefile (+30/-0)
README.md (+5/-0)
files/jenkins-slave-sudoers (+5/-0)
hooks/configure-slave (+0/-27)
hooks/install.d/add_sudoers (+0/-18)
hooks/install.d/canonical_ci_utils.py (+0/-91)
hooks/nrpe-external-master-relation-changed (+0/-7)
hooks/slave-relation-changed (+0/-19)
hooks/slave-relation-departed (+0/-3)
hooks/slave-relation-joined (+0/-20)
hooks/start (+0/-3)
hooks/stop (+0/-3)
layer.yaml (+5/-0)
metadata.yaml (+5/-1)
reactive/jenkins_slave.py (+228/-118)
requirements.txt (+1/-0)
revision (+0/-1)
templates/jenkins-slave-default (+8/-0)
tests/functional/requirements.txt (+6/-0)
tests/functional/test_jenkins_slave.py (+50/-0)
tests/unit/files/jenkins-slave-default (+59/-0)
tests/unit/requirements.txt (+5/-0)
tests/unit/test_jenkins_slave.py (+218/-0)
tox.ini (+37/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

51. By Haw Loeung on 2019-03-01

Fixed to use the module itself instead of sys.modules

50. By Haw Loeung on 2019-03-01

Added basic functional test

49. By Haw Loeung on 2019-03-01

Added unit tests for configure_jenkins_slave()

48. By Haw Loeung on 2019-03-01

Updated test_hook_install() to ensure the correct set of packages are to be installed

47. By Haw Loeung on 2019-03-01

Fixed unit tests in test_hook_install()

46. By Haw Loeung on 2019-02-28

Added incomplete unit tests for install hook. Need to move bulk of code to lib/

45. By Haw Loeung on 2019-02-28

Add note about interface:jenkins-slave lacking providing the slave relation so cannot be used at this stage

44. By Haw Loeung on 2019-02-28

Fixed test_hook_config_changed()

43. By Haw Loeung on 2019-02-28

Fixed assertions making it clearer

42. By Haw Loeung on 2019-02-28

Fixed importing to make it clear we're using charms.reactive