~hloeung/content-cache-charm:reduce-complexity

Branch merges

Propose for merging

Rejected for merging into content-cache-charm:master

Haw Loeung: Needs Resubmitting on 2019-08-06

Joel Sing (community): Needs Fixing on 2019-07-31

Canonical IS Reviewers: Pending requested 2019-07-30

Diff: 199 lines (+34/-34)

5 files modified

lib/haproxy.py (+2/-2)
lib/nginx.py (+5/-5)
reactive/content_cache.py (+12/-12)
tests/unit/test_content_cache.py (+10/-10)
tests/unit/test_nginx.py (+5/-5)

api

Merged into content-cache-charm:master at revision 8ab3a8e96b46668580947a47192a923353bf84ae

Stuart Bishop (community): Approve on 2019-07-22

Canonical IS Reviewers: Pending requested 2019-07-20

Diff: 145 lines (+30/-41)

4 files modified

lib/nginx.py (+25/-1)
reactive/content_cache.py (+1/-22)
tests/unit/files/nginx_config_rendered_test_output-site3.local.txt (+1/-0)
tests/unit/test_nginx.py (+3/-18)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

71464be... by Haw Loeung on 2019-07-30

Fixed mixing underscores and dashes for cache max-size, cache path, listen address, and listen port

12dc271... by Haw Loeung on 2019-07-30

Fixed mixing underscores and dashes for cache port

6f1a85b... by Haw Loeung on 2019-07-30

Fixed mixing underscores and dashes for backend port

174243f... by Haw Loeung on 2019-07-24

layer:apt isn't used as we're using layer:basic's 'packages'.

Reviewed-on: https://code.launchpad.net/~hloeung/content-cache-charm/+git/content-cache-charm/+merge/370532
Reviewed-by: Ryan Finnie <email address hidden>

21bf99a... by Haw Loeung on 2019-07-24

layer:apt isn't used as we're using layer:basic's 'packages'.

8ab3a8e... by Haw Loeung on 2019-07-23

Refactor and reduce complexity in configure_nginx()

Reviewed-on: https://code.launchpad.net/~hloeung/content-cache-charm/+git/content-cache-charm/+merge/370399
Reviewed-by: Stuart Bishop <email address hidden>

83cd476... by Haw Loeung on 2019-07-23

Fixed based on reviews

1075ccd... by Haw Loeung on 2019-07-23

Allow overriding Nginx proxy cache configs - LP: #1825325

Reviewed-on: https://code.launchpad.net/~hloeung/content-cache-charm/+git/content-cache-charm/+merge/370397
Reviewed-by: Stuart Bishop <email address hidden>

d610f7e... by Haw Loeung on 2019-07-20

Refactor and reduce complexity in configure_nginx()

ce7b732... by Haw Loeung on 2019-07-20

Removed unused deepcopy import