~hloeung/content-cache-charm:nginx-config-proxy-cache

Last commit made on 2023-02-03
Get this branch:
git clone -b nginx-config-proxy-cache https://git.launchpad.net/~hloeung/content-cache-charm
Only Haw Loeung can upload to this branch. If you are Haw Loeung please log in for upload directions.

Branch merges

Branch information

Name:
nginx-config-proxy-cache
Repository:
lp:~hloeung/content-cache-charm

Recent commits

1931fe2... by Haw Loeung

Allow overriding proxy_cache - LP:1999704

Succeeded
[SUCCEEDED] lint:0 (build)
[SUCCEEDED] unittest:0 (build)
12 of 2 results
8eb2e74... by Haw Loeung

Only install the LUA packages when monitoring enabled and make that disabled by default - LP:1998873 & LP:1262710

Reviewed-on: https://code.launchpad.net/~hloeung/content-cache-charm/+git/content-cache-charm/+merge/436507
Reviewed-by: Barry Price <email address hidden>

6a9658e... by Haw Loeung

Only install the LUA packages when monitoring enabled and make that disabled by default - LP:1998873 & LP:1262710

Succeeded
[SUCCEEDED] lint:0 (build)
[SUCCEEDED] unittest:0 (build)
12 of 2 results
9a8fe20... by Weii Wang

Use charmcraft to build charm in integration tests

The pytest-operator for integration testing uses `charm` instead of `charmcraft` to build reactive charm. `charm` uses the host environment to build the charm. when the host contains an incorrect version of Python, `charm` will package the incorrect Python package into the charm. `charmcraft` builds the charm using the LXD container with the appropriate Ubuntu image, so there is no such problem with `charmcraft`.

In this commit, change the integration test to call `charmcraft` instead of using `ops_test.build_charm` to build the charm.

Reviewed-on: https://code.launchpad.net/~weii-wang/content-cache-charm/+git/content-cache-charm/+merge/434637
Reviewed-by: Haw Loeung <email address hidden>
Reviewed-by: Colin Watson <email address hidden>

152edec... by Weii Wang

Use short-form bases in metadata.yaml

789e443... by Colin Watson

Remove functional tests

Reviewed-on: https://code.launchpad.net/~cjwatson/content-cache-charm/+git/content-cache-charm/+merge/434621
Reviewed-by: Haw Loeung <email address hidden>

7f12bce... by Weii Wang

Check the existence of charmcraft before building

d7bfb55... by Weii Wang

Use charmcraft to build charm in integration tests

b0d11c8... by Colin Watson

Remove functional tests

They didn't work properly for a couple of reasons:

 * Since commit bf9aa16221ed3fc2daf1a98343798c8d9e428aff, the `build`
   target that `make functional` depended on is no longer present, so
   you had to build the charm manually and unpack it into
   `builds/content-cache/` in a Juju repository somewhere, or else build
   it with `charmcraft pack` and hack the functional tests to point to
   the resulting `.charm` file.

 * The tests aren't quite compatible with the current version of
   `pytest-asyncio` for some reason.

Furthermore, the integration tests are completely a superset of the
functional tests: they deal with building the charm to test themselves,
they cover the same general ground of deploying the charm using Juju to
see what happens, and they test more than the functional tests do. So
it doesn't really make much sense to have both, especially considering
that both functional and integration tests are quite slow.

326248b... by Colin Watson

Use email address in maintainers metadata

Reviewed-on: https://code.launchpad.net/~cjwatson/content-cache-charm/+git/content-cache-charm/+merge/434599
Reviewed-by: Haw Loeung <email address hidden>