Content Cache Charm

Merge ~hloeung/content-cache-charm:master into content-cache-charm:master

  1. Git
  2. lp:~hloeung/content-cache-charm
  3. master
  4. Merge into master
Proposed by Haw Loeung
Status: Superseded
Proposed branch: ~hloeung/content-cache-charm:master
Merge into: content-cache-charm:master
Diff against target: 15 lines (+3/-1)
1 file modified
config.yaml (+3/-1)
Reviewer Review Type Date Requested Status
Joel Sing (community) +1 Approve
Stuart Bishop (community) Approve
Review via email: mp+370237@code.launchpad.net

This proposal has been superseded by a proposal from 2019-07-17.

Commit message

Auto-calculate how much storage space to use for the cache by default

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Stuart Bishop (stub) wrote :

Looks good. Some inline comments for consideration.

review: Approve
Revision history for this message
Haw Loeung (hloeung) :
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision dc418ecc94fb76d0d7253e20c8022f18dca4ce06

Revision history for this message
Joel Sing (jsing) wrote :

LGTM, see comment inline.

review: Approve (+1)

Unmerged commits

316840b... by Haw Loeung

Updated config description to better explain how cache storage space is calculated.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/config.yaml b/config.yaml
2index fda6cf7..7f6d083 100644
3--- a/config.yaml
4+++ b/config.yaml
5@@ -3,7 +3,9 @@ options:
6 type: string
7 default: ""
8 description: |
9- Maximum size of content cache storage. Defaults to auto-calculate (empty/unset).
10+ Maximum size of content cache storage. If unspecified, the maximum cache
11+ storage size will be set to 75% of the total disk space, using a 1GB
12+ minimum size.
13 cache_path:
14 type: string
15 default: "/var/lib/nginx/proxy"

Subscribers

People subscribed via source and target branches