Merge ~hloeung/charm-telegraf:master into charm-telegraf:master

Proposed by Haw Loeung
Status: Merged
Approved by: Xav Paice
Approved revision: 4ebfeb6f7a99bddf094ef7caa3c425ec72d64f93
Merged at revision: 207f7fc5d6465f95eca9f48db7348091cb5c1cda
Proposed branch: ~hloeung/charm-telegraf:master
Merge into: charm-telegraf:master
Diff against target: 21 lines (+11/-2)
1 file modified
src/wheelhouse.txt (+11/-2)
Reviewer Review Type Date Requested Status
Xav Paice (community) Approve
Junien F Approve
Canonical IS Reviewers Pending
Review via email: mp+403108@code.launchpad.net

Commit message

Pin various packages supporting python3.4 (Trusty)

Description of the change

We still have units/environments running Trusty. Unfortunately, a charm upgrade with the most recently built charm breaks on them.

Instead, we pin the specific python packages which still supports Python 3.4.

https://jaas.ai/u/llama-charmers-next/telegraf/2 was the last version with python3.4 support bundling requests==2.21.0 and urllib3=1.25.7.

https://jaas.ai/u/llama-charmers-next/telegraf/3 adds redis and defusedxml but but versions that dropped python3.4 support.

https://jaas.ai/u/llama-charmers-next/telegraf/4 bundles tenacity (from updated layer-snap).

This has been tested to also work on Focal - https://paste.ubuntu.com/p/NNtScTBySz/
(I built and pushed to cs:~hloeung/telegraf)

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Junien F (axino) wrote :

+1

review: Approve
Revision history for this message
Xav Paice (xavpaice) wrote :

lgtm

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 207f7fc5d6465f95eca9f48db7348091cb5c1cda

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/wheelhouse.txt b/src/wheelhouse.txt
2index 0c0ecf7..b0fc52d 100644
3--- a/src/wheelhouse.txt
4+++ b/src/wheelhouse.txt
5@@ -1,5 +1,14 @@
6-requests
7-urllib3
8+# https://github.com/juju-solutions/layer-basic/pull/197
9+MarkupSafe<2.0.0
10+
11+# Support for python3.4 (Trusty)
12+defusedxml<0.6.0
13+redis<3.4.0
14+requests<2.22.0
15+urllib3<1.25.8
16+# https://code.launchpad.net/~hloeung/layer-snap/+git/layer-snap/+merge/403105
17+tenacity<5.0.4
18+
19 # insights-core -> lockfile -> pbr
20 # lockfile is retired, and it won't install pbr, specify explicitly here
21 pbr

Subscribers

People subscribed via source and target branches

to all changes: