Merge ~hloeung/charm-k8s-content-cache:master into charm-k8s-content-cache:master

Proposed by Haw Loeung
Status: Merged
Approved by: Haw Loeung
Approved revision: 54658b36456a18e5b41d3bceb2036e853c4b4ff4
Merged at revision: 45046f9f649f93695b9996a7a103aa7f469c55ca
Proposed branch: ~hloeung/charm-k8s-content-cache:master
Merge into: charm-k8s-content-cache:master
Diff against target: 65 lines (+21/-9)
2 files modified
README.md (+20/-9)
config.yaml (+1/-0)
Reviewer Review Type Date Requested Status
Laurent Sesquès Approve
Canonical IS Reviewers Pending
Review via email: mp+393021@code.launchpad.net

Commit message

Use default image contentcachecharmers/content-cache:edge and update README to suit

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Laurent Sesquès (sajoupa) wrote :

+1

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 45046f9f649f93695b9996a7a103aa7f469c55ca

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/README.md b/README.md
2index aaaae75..b1002ff 100644
3--- a/README.md
4+++ b/README.md
5@@ -6,20 +6,13 @@ Deploy content caching layer into K8s.
6
7 ## Usage
8
9-Build the docker image:
10-
11- `cd docker`
12- `docker build . -t myimage:v<revision>`
13- `docker tag myimage:v<revision> localhost:32000/myimage:v<revision>`
14- `docker push localhost:32000/myimage:v<revision>`
15-
16 Build the charm:
17
18 `charmcraft build`
19
20 Deploy:
21
22- `juju deploy ./content-cache.charm --config image_path=localhost:32000/myimage:v<revision> --config site=mysite.local --config backend=http://mybackend.local:80`
23+ `juju deploy ./content-cache.charm --config site=mysite.local --config backend=http://mybackend.local:80`
24
25 ### Test Deployment
26
27@@ -27,7 +20,25 @@ Deploy:
28
29 ### Scale Out Usage
30
31-Just run `juju add-unit <application name>`.
32+Just run `juju scale-application <application name> 3`.
33+
34+## Using a Custom Image
35+
36+Build the docker image:
37+
38+ `git clone https://git.launchpad.net/charm-k8s-content-cache`
39+ `cd charm-k8s-content-cache/docker`
40+ `docker build . -t myimage:v<revision>`
41+ `docker tag myimage:v<revision> localhost:32000/myimage:v<revision>`
42+ `docker push localhost:32000/myimage:v<revision>`
43+
44+Then, to use your new image, either replace the `deploy` step above with
45+
46+ `juju deploy ./content-cache.charm --config image_path=localhost:32000/myimage:v<revision> --config site=mysite.local --config backend=http://mybackend.local:80`
47+
48+Or, if you have already deployed content-cache:
49+
50+ `juju config content-cache image_path=localhost:32000/myimage:v<revision>`
51
52 ## Developing
53
54diff --git a/config.yaml b/config.yaml
55index 141b70d..d7dcb7c 100644
56--- a/config.yaml
57+++ b/config.yaml
58@@ -5,6 +5,7 @@ options:
59 The location of the image to use, e.g. "localhost:32000/myimage:latest"
60
61 This setting is required.
62+ default: contentcachecharmers/content-cache:edge
63 image_username:
64 type: string
65 description: >-

Subscribers

People subscribed via source and target branches