Merge ~hloeung/apt-stresstest-charm:master into apt-stresstest-charm:master

[Haw Loeung]

Add rotating of logs

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Barry Price (barryprice)]

+1

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision fb396a4699c3ac6a6cf54b185859dad5ed6e7f81

diff --git a/files/logrotate.conf b/files/logrotate.conf
new file mode 100644
index 0000000..7d08670
--- /dev/null
+++ b/files/logrotate.conf
@@ -0,0 +1,8 @@
+/var/log/apt-stresstest.log {
+    daily
+    missingok
+    rotate 90
+    compress
+    delaycompress
+    notifempty
+}
diff --git a/reactive/apt_stresstest.py b/reactive/apt_stresstest.py
index 6b9e416..4adeb73 100644
--- a/reactive/apt_stresstest.py
+++ b/reactive/apt_stresstest.py
@@ -39,8 +39,6 @@ LOGFILE = '/var/log/apt-stresstest.log'
 
 MIRROR_CONFIG_PATH = "/etc/apt-stresstest-mirrors.yaml"
 
-IMAGES_CACHE_PATH = "/var/cache/apt-stresstest/images"
-
 
 def stress_test_args():
     config = hookenv.config()
@@ -85,6 +83,11 @@ def install_crontab():
     )
 
 
+def install_logrotate():
+    charm_dir = hookenv.charm_dir()
+    shutil.copy(os.path.join(charm_dir, 'files/logrotate.conf'), '/etc/logrotate.d/apt-stresstest')
+
+
 @when_not('apt-stresstest.host_file')
 def provision_stresstest_mirror_config():
     config = hookenv.config()
@@ -134,7 +137,7 @@ def install_apt_stresstest(exec_relation):
 
     install_script()
     install_crontab()
-    os.makedirs(IMAGES_CACHE_PATH, exist_ok=True)
+    install_logrotate()
 
     with open(LOGFILE, 'a'):
         os.utime(LOGFILE, None)