Merge lp:~hjd/widelands/boost-dependencies into lp:widelands
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 8390 | ||||
Proposed branch: | lp:~hjd/widelands/boost-dependencies | ||||
Merge into: | lp:widelands | ||||
Diff against target: |
42 lines (+8/-2) 3 files modified
.travis.sh (+4/-1) debian/changelog (+3/-0) debian/control (+1/-1) |
||||
To merge this branch: | bzr merge lp:~hjd/widelands/boost-dependencies | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
GunChleoc | Approve | ||
Review via email: mp+326369@code.launchpad.net |
Description of the change
Things take time...
but as promised here are the changes which align the dependencies used for travis and our PPA a bit more.
I'm probably repeating myself a bit, but the reason the PPA broke while we didn't notice anything on travis is that the latter installed libboost-all-dev. This is a metapackage which install all parts of boost including stuff we don't use, so didn't notice that we had picked up a new dependency. The PPA on the other hand installs only the parts of boost we use, and this list hadn't been updated when the new requirement was merged to trunk.
I've changed it now so that travis also only install the parts we need, so that if we suddenly start using boost-foo tomorrow the build will break, prompting an update of required dependencies. We might also save some time on the travis builds since we need to install less packages. (Probably a minimal difference though, if it is noticable in practice)
Thanks for taking care of this :)