Merge lp:~hjd/synaptic/bug1242219 into lp:synaptic

Proposed by Hans Joachim Desserud on 2013-10-26
Status: Merged
Merged at revision: 2145
Proposed branch: lp:~hjd/synaptic/bug1242219
Merge into: lp:synaptic
Diff against target: 12 lines (+1/-1)
1 file modified
gtk/gtkbuilder/window_main.ui (+1/-1)
To merge this branch: bzr merge lp:~hjd/synaptic/bug1242219
Reviewer Review Type Date Requested Status
Robert Roth 2013-10-26 Approve on 2013-10-26
synaptic-developers 2013-10-26 Pending
Review via email: mp+192793@code.launchpad.net

Description of the change

Mark the menu item "_Contents" translatable as suggested in the bug report (and like the others are marked).

Note that I haven't generated a new version of the .pot file including this string, which should probably be done at the same time this is merged.

To post a comment you must log in.
Robert Roth (evfool) wrote :

Thanks for the contribution, this looks OK to me, however I'm not sure whether the pot file has to be regenerated, so I'm asking for another synaptic-developer review.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'gtk/gtkbuilder/window_main.ui'
2--- gtk/gtkbuilder/window_main.ui 2013-09-02 08:00:25 +0000
3+++ gtk/gtkbuilder/window_main.ui 2013-10-26 19:22:26 +0000
4@@ -658,7 +658,7 @@
5 <property name="can_focus">False</property>
6 <child>
7 <object class="GtkImageMenuItem" id="menu_help">
8- <property name="label">_Contents</property>
9+ <property name="label" translatable="yes">_Contents</property>
10 <property name="visible">True</property>
11 <property name="can_focus">False</property>
12 <property name="use_underline">True</property>

Subscribers

People subscribed via source and target branches

to status/vote changes: