Ubuntu QA Website

Merge lp:~hjarrell555/ubuntu-qa-website/bug_1510939 into lp:ubuntu-qa-website

  1. bug_1510939
  2. Merge into drupal7-rewrite
Proposed by Hunter
Status: Merged
Merged at revision: 408
Proposed branch: lp:~hjarrell555/ubuntu-qa-website/bug_1510939
Merge into: lp:ubuntu-qa-website
Diff against target: 17 lines (+4/-1)
1 file modified
modules/qatracker/qatracker.functions.php (+4/-1)
To merge this branch: bzr merge lp:~hjarrell555/ubuntu-qa-website/bug_1510939
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Approve
Review via email: mp+280534@code.launchpad.net

Description of the change

Changed the bug icon to gold on the testsuites page for bugs that have the status of "Fixed Release" or "Fixed Committed".

To post a comment you must log in.
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

Looks good Hunter! However, notice you have rev 406 in this MP, which isn't part of the changes you made. Make sure your bzr branches are clean so your MP's have only what you intend them to have.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'modules/qatracker/misc/goodbug.png'
2Binary files modules/qatracker/misc/goodbug.png 1970-01-01 00:00:00 +0000 and modules/qatracker/misc/goodbug.png 2015-12-15 00:17:37 +0000 differ
3=== modified file 'modules/qatracker/qatracker.functions.php'
4--- modules/qatracker/qatracker.functions.php 2014-10-31 06:53:50 +0000
5+++ modules/qatracker/qatracker.functions.php 2015-12-15 00:17:37 +0000
6@@ -56,7 +56,10 @@
7 $title = wordwrap($bug->title, 75, "<br />");
8
9 # Generate the icon
10- if ($bug->maximportance == 1) {
11+ if ($bug->status === "Fix Released" || $bug->status === "Fix Committed") {
12+ $logo = "goodbug.png";
13+ }
14+ else if ($bug->maximportance == 1) {
15 $logo = "badbug.png";
16 }
17 else {

Subscribers

People subscribed via source and target branches