Merge lp:~hisaki/nova/lp655217 into lp:~hudson-openstack/nova/trunk

[Hisaki Ohara]

Since FLAGS.images_path was not set for nova-compute, I could not launch instances
due to an exception at _fetch_local_image() trying to access to it.
I think that this is the reason of Bug655217.

I'm not sure whether it is global solution, because FLAGS.images_path is defined
in nova/objectstore/image.py too.

[Jay Pipes (jaypipes)]

Hi!

Can you try seeing if, instead of setting the flag manually in /nova/virt/images.py, you do:

from nova.objectstore import image

instead? That should import the images_path flag defined in /nova/objectstore/image.py.

See if just doing the import fixes the bug...

Thanks!
jay

review: Needs Information

[Hisaki Ohara (hisaki)]

Hello!

> from nova.objectstore import image

It works! :-)

You'd like me to update my branch or you do by yourself, since
it is addition of one line fix?

Regards,
Hisaki Ohara

[Jay Pipes (jaypipes)]

> > from nova.objectstore import image
>
> It works! :-)

Awesome :)

> You'd like me to update my branch or you do by yourself, since
> it is addition of one line fix?

No, you can do it! Just remove the import of util and DEFINE_string, and put in the import above. bzr commit and then bzr push. :) I'll approve it then.

Cheers!
jay

[lp:~hisaki/nova/lp655217]

333. By Hisaki Ohara on 2010-10-07

Imported images_path from nova.objectstore for nova-compute. Without its setting,
it fails to launch instances by exception at _fetch_local_image.

[Hisaki Ohara (hisaki)]

> No, you can do it! Just remove the import of util and DEFINE_string, and put
> in the import above. bzr commit and then bzr push. :) I'll approve it then.

OK. Thanks.
I think I did it as rev.333 of my branch (lp:~hisakister/nova/lp655217).
Please inform me, if any issue. It is my first experience of launchpad system.

Regards,
Hisaki Ohara

[Jay Pipes (jaypipes)]

Awesome. Approved.

review: Approve

[Jay Pipes (jaypipes)]

Hisaki, welcome to being a Nova contributor :)

[Hisaki Ohara (hisaki)]

Thanks! I'm happy for that :-)

=== modified file 'nova/virt/images.py'
--- nova/virt/images.py	2010-08-18 21:14:24 +0000
+++ nova/virt/images.py	2010-10-07 14:11:02 +0000
@@ -29,6 +29,7 @@
 from nova import process
 from nova.auth import manager
 from nova.auth import signer
+from nova.objectstore import image
 
 
 FLAGS = flags.FLAGS