Merge lp:~hirt/ocb-addons/6.1_stock-move-tree into lp:ocb-addons/6.1

Proposed by Etienne Hirt
Status: Needs review
Proposed branch: lp:~hirt/ocb-addons/6.1_stock-move-tree
Merge into: lp:ocb-addons/6.1
Diff against target: 21 lines (+2/-2)
1 file modified
stock/stock_view.xml (+2/-2)
To merge this branch: bzr merge lp:~hirt/ocb-addons/6.1_stock-move-tree
Reviewer Review Type Date Requested Status
Pedro Manuel Baeza code review Approve
Review via email: mp+222726@code.launchpad.net

Description of the change

request merge again after addressing review comments

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Etienne,

Thanks for the new MP. Although I wonder why are you still modifying priority on stock.move.tree3, I'm not going to block the MP for this question, because I don't think that this alters behaviour on possible modules relying on that view.

Regards.

review: Approve (code review)
Revision history for this message
Etienne Hirt (hirt) wrote :

Dear Pedro,

Thanks for the approval.

As you mentioned correctly not to remove stock.move.tree3 in a stable
version, I wanted to make clear that this view is less important by
changing the priority. But I agree it has no effect.

BestRegards
Etienne
On 11.06.2014 08:18, Pedro Manuel Baeza wrote:
> Review: Approve code review
>
> Hi, Etienne,
>
> Thanks for the new MP. Although I wonder why are you still modifying priority on stock.move.tree3, I'm not going to block the MP for this question, because I don't think that this alters behaviour on possible modules relying on that view.
>
> Regards.

--
++++++++++++++++++++++++++++++++++++++++++++++
Dr. Etienne Hirt Art of Technology
Director R&D www.art-of-technology.ch
Technoparkstrasse 1 Ph: +41-43-311 77 02
8005 Zurich Sw: +41-43-311 77 00
Switzerland Skype: etiennehirt
==============================================

Unmerged revisions

6844. By Etienne Hirt

correct priority of stock.move.tree2 and 3 as they had the same as stock.move.tree

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'stock/stock_view.xml'
2--- stock/stock_view.xml 2013-09-10 15:12:35 +0000
3+++ stock/stock_view.xml 2014-06-10 20:30:27 +0000
4@@ -1536,7 +1536,7 @@
5 <field name="name">stock.move.tree2</field>
6 <field name="model">stock.move</field>
7 <field name="type">tree</field>
8- <field name="priority" eval="6" />
9+ <field name="priority" eval="18" />
10 <field name="arch" type="xml">
11 <tree colors="grey:state == 'cancel'" string="Moves">
12 <field name="picking_id" string="Reference"/>
13@@ -1576,7 +1576,7 @@
14 <field name="name">stock.move.tree3</field>
15 <field name="model">stock.move</field>
16 <field name="type">tree</field>
17- <field eval="6" name="priority"/>
18+ <field eval="20" name="priority"/>
19 <field name="arch" type="xml">
20 <tree string="Moves">
21 <field name="picking_id" string="Reference"/>

Subscribers

People subscribed via source and target branches