Code review comment for lp:~hirt/ocb-addons/6.1_fix_mailaddress-parsing
Revision history for this message
| Etienne Hirt (hirt) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
Dear Stefan,
Thanks for the comments and hints. I fully agree with your doubts in regular expressions. I have the same fear. That's why I had one of my employees that often uses regular expressions in Perl etc to help me.
We use this RE now since 15.3.13 daily to import emails from our imap server into Openerp to be assigned to projects, purchase orders, opportunities etc. without any fails.
The getaddresses function as well as the self built addrparser in the pastebin can not cope with troubles like "'bla@2.ch'" <bla@2.ch>.
I'm therefore convinced from the proposed approach.