Merge lp:~hirt/ocb-addons/6.1-ocb_incoming-shipments_remove-company-address-restriction into lp:ocb-addons/6.1

Proposed by Etienne Hirt
Status: Needs review
Proposed branch: lp:~hirt/ocb-addons/6.1-ocb_incoming-shipments_remove-company-address-restriction
Merge into: lp:ocb-addons/6.1
Diff against target: 49 lines (+1/-1)
1 file modified
stock/stock_view.xml (+1/-1)
To merge this branch: bzr merge lp:~hirt/ocb-addons/6.1-ocb_incoming-shipments_remove-company-address-restriction
Reviewer Review Type Date Requested Status
Omar (Pexego) code review Disapprove
Stefan Rijnhart (Opener) Needs Information
Holger Brunn (Therp) code review Approve
Review via email: mp+200443@code.launchpad.net

Description of the change

Only applies for 6.1. 7.0 does not have this problem

To post a comment you must log in.
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

I'm afraid I fail to see the validity of the bug. If I remember correctly, private persons in the old partner model had to be created as a full blown res.partner anyway to be able to purchase from them or receive invoices. What is the meaning of having an address without a partner that you want to receive a shipment from?

review: Needs Information
6825. By Etienne Hirt

commit removed executables

6826. By Etienne Hirt

merge updates of branch

Revision history for this message
Omar (Pexego) (omar7r) wrote :

This proposal could cause errors if you invoice without partner, for example.

review: Disapprove (code review)
Revision history for this message
Etienne Hirt (hirt) wrote :

Dear Stefan, Dear Omar,

Please reconsider my proposal as:
1. There is no requirement on partner.address to have a partner
2. There is no limit on outgoing delivery notes to send to a private address
3. Returns can therefore also come from private address
4. Billing of incoming shipments should come from a purchase order not from a delivery like billing from deliveries should come from sales order

Thanks for helping making the flows consistent.

Unmerged revisions

6826. By Etienne Hirt

merge updates of branch

6825. By Etienne Hirt

commit removed executables

6824. By Etienne Hirt

remove restriction to company addresses in incoming deliveries

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_asset/i18n/ca.po' (properties changed: +x to -x)
2=== modified file 'account_asset/i18n/de.po' (properties changed: +x to -x)
3=== modified file 'account_asset/i18n/es.po' (properties changed: +x to -x)
4=== modified file 'account_asset/i18n/es_CR.po' (properties changed: +x to -x)
5=== modified file 'account_asset/i18n/fr.po' (properties changed: +x to -x)
6=== modified file 'account_asset/i18n/fr_BE.po' (properties changed: +x to -x)
7=== modified file 'account_asset/i18n/pl.po' (properties changed: +x to -x)
8=== modified file 'account_asset/i18n/pt.po' (properties changed: +x to -x)
9=== modified file 'account_asset/i18n/sv.po' (properties changed: +x to -x)
10=== modified file 'account_asset/security/ir.model.access.csv' (properties changed: +x to -x)
11=== modified file 'account_asset/wizard/__init__.py' (properties changed: +x to -x)
12=== modified file 'account_asset/wizard/account_asset_change_duration.py' (properties changed: +x to -x)
13=== modified file 'account_asset/wizard/wizard_asset_compute.py' (properties changed: +x to -x)
14=== modified file 'base_report_designer/plugin/openerp_report_designer/bin/OOo_run.sh' (properties changed: +x to -x)
15=== modified file 'document/odt2txt.py' (properties changed: +x to -x)
16=== modified file 'document/test_cindex.py' (properties changed: +x to -x)
17=== modified file 'document_ftp/ftpserver/ftpserver.py' (properties changed: +x to -x)
18=== modified file 'document_webdav/test_davclient.py' (properties changed: +x to -x)
19=== modified file 'email_template/html2text.py' (properties changed: +x to -x)
20=== modified file 'l10n_ch/report/ocrbb.ttf' (properties changed: +x to -x)
21=== modified file 'l10n_ch/test/test.v11' (properties changed: +x to -x)
22=== modified file 'l10n_ch/test/test_part_1.v11' (properties changed: +x to -x)
23=== modified file 'l10n_ch/test/test_part_2.v11' (properties changed: +x to -x)
24=== modified file 'mail/static/scripts/openerp_mailgate.py' (properties changed: +x to -x)
25=== modified file 'plugin_thunderbird/static/thunderbird_plugin/install.sh' (properties changed: +x to -x)
26=== modified file 'purchase/purchase.py' (properties changed: +x to -x)
27=== modified file 'purchase/wizard/purchase_line_invoice.py' (properties changed: +x to -x)
28=== modified file 'purchase_double_validation/test/purchase_double_validation_test.yml' (properties changed: +x to -x)
29=== modified file 'purchase_requisition/test/purchase_requisition_demo.yml' (properties changed: +x to -x)
30=== modified file 'stock/stock_view.xml'
31--- stock/stock_view.xml 2013-09-10 15:12:35 +0000
32+++ stock/stock_view.xml 2014-05-29 23:50:42 +0000
33@@ -1110,7 +1110,7 @@
34 <group colspan="4" col="4">
35 <field name="name" readonly="1"/>
36 <field name="origin"/>
37- <field name="address_id" on_change="onchange_partner_in(address_id)" context="{'contact_display':'partner'}" domain="[('partner_id','&lt;&gt;',False)]" colspan="4"/>
38+ <field name="address_id" on_change="onchange_partner_in(address_id)" context="{'contact_display':'partner'}" colspan="4"/>
39 <field name="invoice_state" string="Invoice Control"/>
40 <field name="backorder_id" readonly="1" groups="base.group_extended"/>
41 </group>
42
43=== modified file 'wiki/static/src/lib/wiky/Readme.md' (properties changed: +x to -x)
44=== modified file 'wiki/static/src/lib/wiky/autogit.sh' (properties changed: +x to -x)
45=== modified file 'wiki/static/src/lib/wiky/index.html' (properties changed: +x to -x)
46=== modified file 'wiki/static/src/lib/wiky/input_complete' (properties changed: +x to -x)
47=== modified file 'wiki/static/src/lib/wiky/jquery-1.4.2.min.js' (properties changed: +x to -x)
48=== modified file 'wiki/static/src/lib/wiky/wiky.css' (properties changed: +x to -x)
49=== modified file 'wiki/static/src/lib/wiky/wiky.js' (properties changed: +x to -x)

Subscribers

People subscribed via source and target branches