Code review comment for lp:~hingo/drizzle/drizzle-the-version-is-7.1-not-a-date-and-certainly-not-7

Mark: None of those errors are due to this patch. It's been confirmed by Daniel yesterday.

They happen when one tries to tag drizzle with a 7.1.x version number. They will happen equally with or without this patch. This patch doesn't mandate version numbers one way or another, it just changes the package name from "drizzle7" to "drizzle".

[23:26:41] <daniel4> vjsamuel: hingo: i'm running tests, so far no errors
[23:26:49] <daniel4> fresh build of latest trunk
[23:26:50] <daniel4> 2501
[23:27:24] <hingo> daniel4: I think the errors happen if you'd do "bzr tag 7.1.31".
[23:31:25] <daniel4> hingo: ok i'll try that after this run to compare the two
[23:32:05] <hingo> daniel4: or to be precise, vjsamuel did bzr tag 7.1.31-rc but the -rc shouldn't matter.
[23:33:57] <daniel4> All 566 tests were successful.
[23:34:03] --> davidstrauss (~straussd@wikimedia/davidstrauss) has joined #drizzle
[23:34:38] <daniel4> hingo: do i have to re-compile after bzr tag 7.1.31 ? because i don't have enough battery for that heh
[23:35:10] <hingo> daniel4: yes. config/autorun.sh takes latest tag as input.
[23:35:53] <daniel4> hingo: ah, well in that case ^ (vjsamuel) I'll have to try again later today because my battery can't survive another recompile.

[00:46:49] <daniel4> vjsamuel: still online?
[00:47:22] <daniel4> hingo: you still online?
[01:03:23] <daniel4> well in any case, after tagging bzr trunk with 7.1.31 the errors happen on my box too
[01:09:23] <daniel4> hingo: vjsamuel: sent you two an email on why those tests are failing
[01:09:33] -*- daniel4 goes offline again