Merge lp:~hingo/drizzle/drizzle-remove-Wall-in-autorunsh into lp:~drizzle-trunk/drizzle/development
| Status: | Rejected |
|---|---|
| Rejected by: | Mark Atwood on 2012-02-14 |
| Proposed branch: | lp:~hingo/drizzle/drizzle-remove-Wall-in-autorunsh |
| Merge into: | lp:~drizzle-trunk/drizzle/development |
| Diff against target: |
9 lines (+1/-1) 1 file modified
config/autorun.sh (+1/-1) |
| To merge this branch: | bzr merge lp:~hingo/drizzle/drizzle-remove-Wall-in-autorunsh |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Henrik Ingo | Disapprove on 2012-02-10 | ||
| Mark Atwood | Needs Information on 2012-02-10 | ||
| Drizzle Merge Team | 2012-02-08 | Pending | |
|
Review via email:
|
|||
Description of the change
Recent autoconf changes by Brian made config/autorun.sh fail spectacularly on (K)Ubuntu 11.10. Removing -Wall makes it work again.
| Henrik Ingo (hingo) wrote : | # |
Hmm... good point. Do the buildslaves have standard autotools installed?
Note that the same warnings do happen:
configure.ac:143: the top level
configure.ac:143: warning: The macro `AC_TRY_LINK' is obsolete.
configure.ac:143: You should run autoupdate.
For some reason this results in a failure on my workstation, but apparently the build continues on the slave.
| Henrik Ingo (hingo) wrote : | # |
Ok, working from newest trunk works for me now too. I get the warnings but it doesn't error out.
What is the process for invalidating? Should I remove this branch?
| Stewart Smith (stewart) wrote : | # |
On Fri, 10 Feb 2012 15:01:24 -0000, Henrik Ingo <email address hidden> wrote:
> Review: Disapprove
>
> Ok, working from newest trunk works for me now too. I get the warnings but it doesn't error out.
>
> What is the process for invalidating? Should I remove this branch?
You can set the status of the merge req to 'rejected'
--
Stewart Smith
| Henrik Ingo (hingo) wrote : | # |
Actually, I can't. I have just Work In Progress, Needs Review and Merged. (It seems like Launchpad doesn't allow me to give up :-)
| Stewart Smith (stewart) wrote : | # |
On Sun, 12 Feb 2012 07:13:19 -0000, Henrik Ingo <email address hidden> wrote:
> Actually, I can't. I have just Work In Progress, Needs Review and
> Merged. (It seems like Launchpad doesn't allow me to give up :-)
hrrm... maybe this is an option that's reserved for the drizzle-trunk
group... so Brian or Mark or someone can do it :)
--
Stewart Smith
Unmerged revisions
- 2504. By Henrik Ingo on 2012-02-08
-
autoreconf -Wall creates a lot of trouble on (K)Ubuntu 11.10.
Removing -Wall helps.
It passed on http://