Some style comments, I hope you don't mind.
206 +namespace drizzle_plugin { 207 + 208 +namespace js {
Redundant empty line
220 +class JsFunction :public Item_str_func
Missing space after ':'
221 +{ 222 +public: 223 + JsFunction() :Item_str_func() {} 224 + ~JsFunction() {}
Empty constructors and destructors aren't necessary.
260 +void emit_drizzle_error(v8::TryCatch* try_catch) {
'{' should be on the next line
Greetings,
Olaf
« Back to merge proposal
Some style comments, I hope you don't mind.
206 +namespace drizzle_plugin {
207 +
208 +namespace js {
Redundant empty line
220 +class JsFunction :public Item_str_func
Missing space after ':'
221 +{
222 +public:
223 + JsFunction() :Item_str_func() {}
224 + ~JsFunction() {}
Empty constructors and destructors aren't necessary.
260 +void emit_drizzle_ error(v8: :TryCatch* try_catch) {
'{' should be on the next line
Greetings,
Olaf