Merge lp:~hikiko/unity/unity.menus-anim-lowgfx into lp:unity
Proposed by
Eleni Maria Stea
Status: | Rejected |
---|---|
Rejected by: | Marco Trevisan (Treviño) |
Proposed branch: | lp:~hikiko/unity/unity.menus-anim-lowgfx |
Merge into: | lp:unity |
Prerequisite: | lp:~hikiko/unity/unity.scale-expo-lowgfx-and-mmon-fix |
Diff against target: |
24 lines (+14/-0) 1 file modified
plugins/unityshell/src/unityshell.cpp (+14/-0) |
To merge this branch: | bzr merge lp:~hikiko/unity/unity.menus-anim-lowgfx |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Marco Trevisan (Treviño) | Needs Fixing | ||
PS Jenkins bot | continuous-integration | Pending | |
Review via email: mp+298859@code.launchpad.net |
Commit message
some settings for low gfx mode
Description of the change
some settings for low gfx mode
To post a comment you must log in.
Mh, as quickly discussed in IRC I think this approach isn't the best for some reasons:
- Main issue to me is that in this way, the user options get overridden and
once you disable the lowgfx settings these are not updated, or reset to default.
- You'd also need to keep these options updated when LogGfx setting change
- From my tests, this branch doesn't do anything here (quite weird).
So, I suggest instead of changing compiz to have a flag to define wheter is in low-gfx mode or not, and then use this setting to bypass some things in both unity and compiz, bypassing the user settings in that case, not changing them or overriding.
I suggest you to use the "Slow animation" keybinding (set it under Composite plugin options), to check whether the changes apply or not.
Finally, one more thing you should do, that is probably more visible than these is disabling the fade animations for views.
This diff (http:// pastebin. ubuntu. com/18221580/) should cover most of the places, but is still missing a change: you need to update the animation duration when the setting changes, or this won't work dynamically.