Merge lp:~hikiko/unity/unity.fixed-tests-wwarnings into lp:unity

[Eleni Maria Stea]

Replaced deprecated calls in tests to get rid of compiler warnings

Replaced deprecated calls in tests to get rid of compiler warnings

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:4028
http://jenkins.qa.ubuntu.com/job/unity-ci/1322/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-wily-amd64-ci/100/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-wily-armhf-ci/98/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-wily-i386-ci/98/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/1322/rebuild

review: Needs Fixing (continuous-integration)

[Marco Trevisan (Treviño) (3v1n0)]

+1

review: Approve

[Marco Trevisan (Treviño) (3v1n0)]

I'm not sure whether this is related, but it seems it causes a segmentation fault on powerpc builds.

https://launchpadlibrarian.net/225695938/buildlog_ubuntu-xenial-powerpc.unity_7.4.0%2B16.04.20151110.2-0ubuntu1_BUILDING.txt.gz

Also looking at this better, the arguments order has to be fixed; while you should use the GTask API everywhere, getting rid of G_ASYNC_RESULT too.

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:4030
http://jenkins.qa.ubuntu.com/job/unity-ci/1350/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-xenial-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-xenial-armhf-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-xenial-i386-ci/2

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/1350/rebuild

review: Approve (continuous-integration)

[Marco Trevisan (Treviño) (3v1n0)]

+1

review: Approve

=== modified file 'tests/gmockvolume.c'
--- tests/gmockvolume.c	2013-10-07 13:45:13 +0000
+++ tests/gmockvolume.c	2015-11-11 07:27:39 +0000
@@ -234,7 +234,7 @@
   g_mock_volume_set_mount(mock_volume, G_MOUNT(g_mock_mount_new()));
 
   callback(G_OBJECT (volume),
-           G_ASYNC_RESULT (g_simple_async_result_new (G_OBJECT (volume), callback, user_data, NULL)),
+           G_TASK (g_task_new (G_OBJECT (volume), NULL, callback, user_data)),
            user_data);
 }
 
@@ -254,7 +254,7 @@
                      gpointer             user_data)
 {
   callback(G_OBJECT (volume),
-           G_ASYNC_RESULT (g_simple_async_result_new (G_OBJECT (volume), callback, user_data, NULL)),
+           G_TASK (g_task_new (G_OBJECT (volume), NULL, callback, user_data)),
            user_data);
 }