Merge lp:~hikiko/unity/unity.fixed-tests-wwarnings into lp:unity

Proposed by Eleni Maria Stea on 2015-10-27
Status: Merged
Approved by: Marco Trevisan (Treviño) on 2015-11-17
Approved revision: 4030
Merged at revision: 4048
Proposed branch: lp:~hikiko/unity/unity.fixed-tests-wwarnings
Merge into: lp:unity
Diff against target: 20 lines (+2/-2)
1 file modified
tests/gmockvolume.c (+2/-2)
To merge this branch: bzr merge lp:~hikiko/unity/unity.fixed-tests-wwarnings
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) 2015-10-27 Approve on 2015-11-17
PS Jenkins bot (community) continuous-integration Approve on 2015-11-11
Review via email: mp+275801@code.launchpad.net

Commit message

Replaced deprecated calls in tests to get rid of compiler warnings

Description of the change

Replaced deprecated calls in tests to get rid of compiler warnings

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Marco Trevisan (Treviño) (3v1n0) wrote :

+1

review: Approve
Marco Trevisan (Treviño) (3v1n0) wrote :

I'm not sure whether this is related, but it seems it causes a segmentation fault on powerpc builds.

https://launchpadlibrarian.net/225695938/buildlog_ubuntu-xenial-powerpc.unity_7.4.0%2B16.04.20151110.2-0ubuntu1_BUILDING.txt.gz

Also looking at this better, the arguments order has to be fixed; while you should use the GTask API everywhere, getting rid of G_ASYNC_RESULT too.

review: Needs Fixing
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Marco Trevisan (Treviño) (3v1n0) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/gmockvolume.c'
2--- tests/gmockvolume.c 2013-10-07 13:45:13 +0000
3+++ tests/gmockvolume.c 2015-11-11 07:27:39 +0000
4@@ -234,7 +234,7 @@
5 g_mock_volume_set_mount(mock_volume, G_MOUNT(g_mock_mount_new()));
6
7 callback(G_OBJECT (volume),
8- G_ASYNC_RESULT (g_simple_async_result_new (G_OBJECT (volume), callback, user_data, NULL)),
9+ G_TASK (g_task_new (G_OBJECT (volume), NULL, callback, user_data)),
10 user_data);
11 }
12
13@@ -254,7 +254,7 @@
14 gpointer user_data)
15 {
16 callback(G_OBJECT (volume),
17- G_ASYNC_RESULT (g_simple_async_result_new (G_OBJECT (volume), callback, user_data, NULL)),
18+ G_TASK (g_task_new (G_OBJECT (volume), NULL, callback, user_data)),
19 user_data);
20 }
21