Unity

Merge lp:~hikiko/unity/unity.disable-shadows-lowgfx into lp:unity

  1. unity.disable-shadows-lowgfx
  2. Merge into trunk
Proposed by Eleni Maria Stea on 2016-07-05
Status: Rejected
Rejected by: Marco Trevisan (Treviño) on 2016-07-05
Proposed branch: lp:~hikiko/unity/unity.disable-shadows-lowgfx
Merge into: lp:unity
Diff against target: 12 lines (+1/-1)
1 file modified
decorations/DecoratedWindow.cpp (+1/-1)
To merge this branch: bzr merge lp:~hikiko/unity/unity.disable-shadows-lowgfx
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) 2016-07-05 Disapprove on 2016-07-05
PS Jenkins bot continuous-integration Pending
Review via email: mp+299111@code.launchpad.net

Commit Message

disable shadows in low gfx mode

Description of the Change

disable shadows in low gfx mode

To post a comment you must log in.
Marco Trevisan (Treviño) (3v1n0) wrote :

This is already included in the new unity-lowgfx profile, as discussed.

review: Disapprove

Unmerged revisions

4136. By Eleni Maria Stea on 2016-07-05

disable shadows for low gfx mode

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'decorations/DecoratedWindow.cpp'
2--- decorations/DecoratedWindow.cpp 2016-04-01 00:50:30 +0000
3+++ decorations/DecoratedWindow.cpp 2016-07-05 08:32:51 +0000
4@@ -720,7 +720,7 @@
5 glwin_->glAddGeometry(quad.matrices, quad.region, clip_region);
6 }
7
8- if (glwin_->vertexBuffer()->end())
9+ if (glwin_->vertexBuffer()->end() && !unity::Settings::Instance().GetLowGfxMode())
10 glwin_->glDrawTexture(ShadowTexture(), transformation, attrib, mask);
11
12 for (auto const& dtex : bg_textures_)