Merge lp:~hikiko/nux/nux.virt-destructors into lp:nux

[Eleni Maria Stea]

added virtual destructors where missing (fixing static analysis errors)

added virtual destructors where missing (fixing static analysis errors)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:827
http://jenkins.qa.ubuntu.com/job/nux-ci/91/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-trusty-amd64-ci/13
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-trusty-armhf-ci/13
    SUCCESS: http://jenkins.qa.ubuntu.com/job/nux-trusty-i386-ci/13

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/nux-ci/91/rebuild

review: Approve (continuous-integration)

[Brandon Schaefer (brandontschaefer)]

LGTM

review: Approve

[Brandon Schaefer (brandontschaefer)]

Actually this break the ABI for nux, but i also heard this was talked about...so for now just moving to needs fixing :)

review: Needs Fixing

[Brandon Schaefer (brandontschaefer)]

Merging this first, then nux perf branch which will handle the ABI break

review: Approve

=== modified file 'NuxCore/AnimationController.h'
--- NuxCore/AnimationController.h	2012-11-05 21:31:06 +0000
+++ NuxCore/AnimationController.h	2013-11-05 13:37:55 +0000
@@ -53,7 +53,7 @@
   static Controller* Instance();
 
   Controller();
-  ~Controller();
+  virtual ~Controller();
 
   virtual void AddAnimation(Animation* animation) = 0;
   virtual void RemoveAnimation(Animation* animation) = 0;
@@ -74,7 +74,7 @@
 {
 public:
   AnimationController(TickSource& tick_source);
-  ~AnimationController();
+  virtual ~AnimationController();
 
   // tick is expected to be ever increasing
   virtual void OnTick(long long tick);

=== modified file 'NuxCore/Property.h'
--- NuxCore/Property.h	2013-07-18 17:27:55 +0000
+++ NuxCore/Property.h	2013-11-05 13:37:55 +0000
@@ -192,6 +192,7 @@
 class PropertyBase
 {
 public:
+  virtual ~PropertyBase() {}
   virtual bool SetValue(std::string const& serialized_form) = 0;
   virtual std::string GetSerializedValue() const = 0;
 };

=== modified file 'NuxGraphics/GLResourceManager.h'
--- NuxGraphics/GLResourceManager.h	2012-09-26 06:44:12 +0000
+++ NuxGraphics/GLResourceManager.h	2013-11-05 13:37:55 +0000
@@ -165,6 +165,7 @@
     NResourceFactory(NObjectType *Type)
       :   m_ResourceType(Type)
     {}
+    virtual ~NResourceFactory() {}
 
     // Returns the resource type for this factory
     const NObjectType &Type() const

=== modified file 'tests/gtest-nux-gesturebroker.cpp'
--- tests/gtest-nux-gesturebroker.cpp	2012-12-05 08:40:25 +0000
+++ tests/gtest-nux-gesturebroker.cpp	2013-11-05 13:37:55 +0000
@@ -29,6 +29,7 @@
 {
   public:
     SimpleTarget(int id) : id(id) {}
+    virtual ~SimpleTarget() {}
     virtual GestureDeliveryRequest GestureEvent(const nux::GestureEvent &/* event */)
     {
       return GestureDeliveryRequest::NONE;
@@ -45,6 +46,7 @@
 class SimpleGestureBroker : public nux::GestureBroker
 {
 public:
+  virtual ~SimpleGestureBroker() {}
   std::vector<ShPtGestureTarget> targets_to_be_found;
 
 private: