Compiz

Merge lp:~hikiko/compiz/compiz.handles-chrome-chromium-windows-in-fullscreen into lp:compiz/0.9.12

  1. compiz.handles-chrome-chromium-windows-in-fullscreen
  2. Merge into 0.9.12
Proposed by Eleni Maria Stea on 2016-01-13
Status: Merged
Approved by: Marco Trevisan (Treviño) on 2016-02-02
Approved revision: 3996
Merged at revision: 3994
Proposed branch: lp:~hikiko/compiz/compiz.handles-chrome-chromium-windows-in-fullscreen
Merge into: lp:compiz/0.9.12
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/composite/composite.xml.in (+1/-1)
To merge this branch: bzr merge lp:~hikiko/compiz/compiz.handles-chrome-chromium-windows-in-fullscreen
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve on 2016-02-02
Marco Trevisan (Treviño) Approve on 2016-02-02
Will Cooke 2016-01-13 Approve on 2016-01-19
Chad Miller (community) 2016-01-13 Approve on 2016-01-13
Review via email: mp+282426@code.launchpad.net

Commit Message

chrome and chromium windows are considered compiz windows in fullscreen to avoid tearing (Bug #1442728)

Description of the Change

chrome and chromium windows are considered compiz windows in fullscreen to avoid tearing (Bug #1442728)

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Chad Miller (cmiller) wrote :

Have you any concern about "mplayer2"?

Chad Miller (cmiller) :
review: Approve
Eleni Maria Stea (hikiko) wrote :

> Have you any concern about "mplayer2"?

Does it have tearing in fullscreen?

Marco Trevisan (Treviño) (3v1n0) wrote :

I guess it's different case.

Also, since you're there include (!class=QtQmlViewer) so that this will fix the problem also for qmlscene

Eleni Maria Stea (hikiko) :
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Will Cooke (willcooke) wrote :

LGTM!

Feedback from Community:

 1 x It wasn't broken for me and this doesn't make it worse
 3 x Yay! This fixes it for me!

Approve.

review: Approve
Eleni Maria Stea (hikiko) wrote :

added google-chrome-unstable in the list

Marco Trevisan (Treviño) (3v1n0) :
review: Approve
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/composite/composite.xml.in'
2--- plugins/composite/composite.xml.in 2012-12-04 11:30:05 +0000
3+++ plugins/composite/composite.xml.in 2016-02-02 14:35:40 +0000
4@@ -29,7 +29,7 @@
5 <option name="unredirect_match" type="match">
6 <_short>Unredirect Match</_short>
7 <_long>Specifies which windows will be unredirected when they are fullscreen. You might want to exclude video players for example, to avoid tearing. But this will be at the expense of performance/frame rate. Note: "class=" matching requires the regex plugin to work.</_long>
8- <default>(any) &amp; !(class=Totem) &amp; !(class=MPlayer) &amp; !(class=Vlc) &amp; !(class=Plugin-container) &amp; !(class=Firefox)</default>
9+ <default>(any) &amp; !(class=Totem) &amp; !(class=MPlayer) &amp; !(class=vlc) &amp; !(class=Plugin-container) &amp; !(class=QtQmlViewer) &amp; !(class=Firefox) &amp; !(class=google-chrome) &amp; !(class=google-chrome-unstable) &amp; !(class=chromium-browser)</default>
10 </option>
11 <option name="force_independent_output_painting" type="bool">
12 <_short>Force independent output painting.</_short>

Subscribers

People subscribed via source and target branches