Compiz

Merge lp:~hikiko/compiz/compiz.fix-811591 into lp:compiz/0.9.12

  1. compiz.fix-811591
  2. Merge into 0.9.12
Proposed by Eleni Maria Stea on 2015-09-25
Status: Work in progress
Proposed branch: lp:~hikiko/compiz/compiz.fix-811591
Merge into: lp:compiz/0.9.12
Diff against target: 23 lines (+0/-10)
1 file modified
plugins/put/src/put.cpp (+0/-10)
To merge this branch: bzr merge lp:~hikiko/compiz/compiz.fix-811591
Reviewer Review Type Date Requested Status
Andrea Azzarone 2015-09-25 Needs Fixing on 2015-10-06
PS Jenkins bot continuous-integration Needs Fixing on 2015-09-25
Marco Trevisan (Treviño) 2015-09-25 Pending
Unity Team 2015-09-25 Pending
Review via email: mp+272359@code.launchpad.net

Commit Message

Fix for put plugin.

Description of the Change

Fix for put plugin.

To post a comment you must log in.
lp:~hikiko/compiz/compiz.fix-811591 updated on 2015-09-25
3979. By Eleni Maria Stea on 2015-09-25

removed comment

PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Reply
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Reply
Andrea Azzarone (azzar1) wrote :

It works now but the two comments are now invalid
/* take the shortest horizontal path to the destination viewport */

and the other one as well:
/* we need to do this for the vertical destination viewport too */

Right?

review: Needs Fixing
Reply
Andrea Azzarone (azzar1) wrote :

Ops actually the problem is still there. I'm using multimunitor with 9 workspaces sending a termianl window from 1 to 8.

review: Needs Fixing
Reply
Eleni Maria Stea (hikiko) wrote :

I forgot to test in multimonitor :/ In progress...

Reply
lp:~hikiko/compiz/compiz.fix-811591 updated on 2015-10-07
3980. By Eleni Maria Stea on 2015-10-07

removed irrelevant comments

Marco Trevisan (Treviño) (3v1n0) wrote :

No worries, I think you can keep this in hold, since put plugin is not relevant for unity.

Reply
Eleni Maria Stea (hikiko) wrote :

+1

Reply

Unmerged revisions

3980. By Eleni Maria Stea on 2015-10-07

removed irrelevant comments

3979. By Eleni Maria Stea on 2015-09-25

removed comment

3978. By Eleni Maria Stea on 2015-09-25

fixes bug: #811591 solution proposed by Sam Spilsbury here:
https://bugs.launchpad.net/compiz/+bug/811591

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/put/src/put.cpp'
2--- plugins/put/src/put.cpp 2013-05-11 14:06:54 +0000
3+++ plugins/put/src/put.cpp 2015-10-07 06:15:10 +0000
4@@ -599,19 +599,9 @@
5 if (vpY > (int) s->vpSize ().height ())
6 vpY = s->vpSize ().height () - 1;
7
8- /* take the shortest horizontal path to the destination viewport */
9 hDirection = (vpX - s->vp ().x ());
10- if (hDirection > (int) s->vpSize ().width () / 2)
11- hDirection = (hDirection - s->vpSize ().width ());
12- else if (hDirection < - ((int) s->vpSize ().width ()) / 2)
13- hDirection = (hDirection + s->vpSize ().width ());
14
15- /* we need to do this for the vertical destination viewport too */
16 vDirection = (vpY - s->vp ().y ());
17- if (vDirection > (int) s->vpSize ().height () / 2)
18- vDirection = (vDirection - s->vpSize ().height ());
19- else if (vDirection < -((int) s->vpSize ().height ()) / 2)
20- vDirection = (vDirection + s->vpSize ().height ());
21
22 dx = s->width () * hDirection;
23 dy = s->height () * vDirection;

Subscribers

People subscribed via source and target branches