Code review comment for lp:~hid-iwata/tortoisebzr/cmenu_customize

Hi, Jelmer.
Thank you for your advice.

I've split this changes into these 3 new branches.

lp:~hid-iwata/tortoisebzr/cmenu_customize2 for "Context menu customizing".
lp:~hid-iwata/tortoisebzr/pathfilter_for_cmenu for "Drive type & path filter"
lp:~hid-iwata/tortoisebzr/cmenu_filter_improve for "Improvement for menu filtering"

1st one is ready to be reviewed.

2nd & 3rd are not ready (I've not reviewed them by myself yet).
I'll make other merge-proposal for 2nd & 3rd in a few days (maybe this weekend).

Cheers.

> Hi!
>
> On Sat, 2010-12-04 at 03:59 +0000, iwata wrote:
> > iwata has proposed merging lp:~hid-iwata/tortoisebzr/cmenu_customize into
> lp:tortoisebzr.
> >
> > Requested reviews:
> > TortoiseBZR Developers (tortoisebzr-developers)
> >
> >
> > Context menu customizing feature
> > ---------------------------------
> > Make it possible to reorder context menus or hide unused menus as users
> like.
> > Related bug : #591774
> >
> > Drive type filter and path filter for context menu
> > -----------------------------------------------------------
> > As same as icon overlays, make it possible to define folders on which tbzr
> avoids showing context menus, with drive type filters and path wildcards.
> >
> > .. note::
> > Some of menus (e.g. ``settings``) are always shown regardless of these
> settings.
> >
> > A little improvement for context menu filtering
> > ------------------------------------------------
> > Hide obviously useless menus (e.g. ``annotate`` when no file selected) even
> when status of files/folders are unavailable.
> Thanks for the patch, this seems like a useful addition. Is there any
> chance you can split this branch up a bit ? That might make it a bit
> easier for reviewer(s) to review and merge it.
>
> Cheers,
>
> Jelmer