Merge lp:~hid-iwata/bzr/fix-mojibake into lp:bzr
Proposed by
IWATA Hidetaka
on 2012-08-09
Status: | Needs review |
---|---|
Proposed branch: | lp:~hid-iwata/bzr/fix-mojibake |
Merge into: | lp:bzr |
Diff against target: |
68 lines (+31/-2) 2 files modified
bzrlib/commands.py (+9/-2) bzrlib/trace.py (+22/-0) |
To merge this branch: | bzr merge lp:~hid-iwata/bzr/fix-mojibake |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
bzr-core | 2012-08-09 | Pending | |
Review via email:
|
Description of the change
Workaround for #777996 and #909152
Unreadable error message can be a huge blocker for newbie users.
This patch may not be perfect, but I think this is better than now.
To post a comment you must log in.
Martin Packman (gz) wrote : | # |
IWATA Hidetaka (hid-iwata) wrote : | # |
All stderr output must be encoded to terminal-encoding, even if stderr.encoding is None. (qbzr requires such behavior)
inside trace.report_
This is the reason why I use wrapped stream.
Unmerged revisions
- 6545. By IWATA Hidetaka on 2012-08-09
-
Consider decoding error.
- 6544. By IWATA Hidetaka on 2012-07-26
-
Fix mojibake of localized error message.
This is close to the right fix for this (longstanding and very annoying) issue.
I really think we want to do the decoding inside trace.report_ exception rather than wrapping the stream passed to allow it to be stupid, what do you think?