Code review comment for lp:~hermann-kaser/pogo/lastfm-plugin

Revision history for this message
Jendrik Seipp (jendrikseipp) wrote :

Thanks for your work Hermann. I think we can make the plugin even better however by using code from decibel, the player pogo was forked from. There a scrobbling plugin was already included. The major benefit is that it doesn't need the additional pylast dependency and has a nice ui integration already. The code would have to be adapted slightly but I guess it should be straightforward.

If you like you can try copying http://bazaar.launchpad.net/~athropos/decibel-audio-player/trunk/view/head:/src/modules/AudioScrobbler.py into pogos modules directory. You will have to remove consts.MODCAT_INTERNET from MOD_INFO, I don't know about other changes.

review: Needs Fixing

« Back to merge proposal