Merge lp:~henryhu/compiz/fix-place into lp:compiz/0.9.12

[Henry Hu]

place plugin: correct min and default placement modes in configuration

fix the Placement Mode option in the place plugin

Currently, because the mismatch of possible values and min/max value, when you select one option for Placement Mode, exit ccsm, and start again, you would find that the option changed to another one.
This also makes the default install to maximize every window. The default value of this option is 0 which is illegal according to current min/max values (2/5).

This patch fixes this behavior. It changes the min value so it matches with the possible options.

[lp:~henryhu/compiz/fix-place]

3891. By Henry Hu on 2014-10-13

change default to smart, according to the original intent

[Henry Hu (henryhu)]

Also change the default to smart. According to
http://bazaar.launchpad.net/~compiz-team/compiz/0.9.12/revision/2880.3.1
, this seems to be the original intent.

[Henry Hu (henryhu)]

Related bug report: https://bbs.archlinux.org/viewtopic.php?id=172549

[Stephen M. Webb (bregma)]

This was orginally "fixed" by bug #873384 in 2011 and then Ubuntu distro-patched it to work correctly in 2012. It should in fact have been fixed correctly upstream, and this MP does just that.

This will require unpatching the Ubuntu distro files, bit that can be done as a separate MP from a Ubuntu maintainer and the two MPs will need to land together.

Approved.

review: Approve

=== modified file 'plugins/place/place.xml.in'
--- plugins/place/place.xml.in	2012-10-15 10:31:51 +0000
+++ plugins/place/place.xml.in	2014-10-13 20:55:25 +0000
@@ -20,8 +20,8 @@
 	    <option name="mode" type="int">
 		<_short>Placement Mode</_short>
 		<_long>Algorithm to use for window placement</_long>
-		<default>0</default>
-		<min>2</min>
+		<default>2</default>
+		<min>0</min>
 		<max>5</max>
 		<desc>
 		    <value>0</value>