Code review comment for lp:~henninge/launchpad/devel-766955-fix-forwardCheckAuthenticated

Gavin Panella (allenap) wrote :

This looks good, but I don't like assertVectorEqual() very much :-/
One minor gripe is that it's not much of an improvement over doing two
assertEqual() calls, but the main problem is that the error messages
won't make sense because they'll contain expected_vector and
observed_vector. In short I think it's better to simply do something
like:

        self.assertEqual(
            (1, 1),
            (adapter.checkPermissionIsRegistered.call_count,
             next_adapter.checkAuthenticated.call_count))

because then the error messages will make sense.

review: Approve

« Back to merge proposal