Merge lp:~henninge/launchpad/devel-705176-sharing-info-link into lp:launchpad
Status: | Merged |
---|---|
Approved by: | Henning Eggers |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12559 |
Proposed branch: | lp:~henninge/launchpad/devel-705176-sharing-info-link |
Merge into: | lp:launchpad |
Prerequisite: | lp:~henninge/launchpad/devel-705176-sharing-info-on-page |
Diff against target: |
414 lines (+204/-8) 9 files modified
lib/lp/translations/browser/potemplate.py (+19/-1) lib/lp/translations/browser/productseries.py (+12/-1) lib/lp/translations/browser/sourcepackage.py (+13/-1) lib/lp/translations/browser/tests/test_sharing_information.py (+78/-5) lib/lp/translations/browser/translationsharing.py (+57/-0) lib/lp/translations/stories/standalone/xx-potemplate-index.txt (+15/-0) lib/lp/translations/templates/potemplate-index.pt (+3/-0) lib/lp/translations/templates/productseries-translations.pt (+4/-0) lib/lp/translations/templates/sourcepackage-translations.pt (+3/-0) |
To merge this branch: | bzr merge lp:~henninge/launchpad/devel-705176-sharing-info-link |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Deryck Hodge (community) | code | Approve | |
Curtis Hovey (community) | ui | Approve | |
Review via email: mp+51891@code.launchpad.net |
Commit message
[r=deryck]
Description of the change
= Summary =
This is the final step in adding sharing information to translation pages. It adds a link to each "Sharing Information" portlet which were introduced in the last branch. The link points to a yet-to-be-created page that will provide detailed information about translation sharing and a place to take the necessary configuration step. Thus the link is named differently depending on the user's permissions to configure these things.
Here are the screenshots used in the UI review.
http://
http://
http://
== Proposed fix ==
I added a Mixin to be used in all the view classes that creates an HTML snippet for the link. This was far easier than putting it together in TAL. The views that use this mixing implement some methods to provide the specific objects.
== Pre-implementation notes ==
Same as before.
== Implementation details ==
A lot of the implementation is extending the test to work with different users to verify that the correct link text is displayed. One trick here was to make sure that the user's password is 'test' because that is what getViewBrowser expects.
== Tests ==
bin/test -vvcm lp.translations
bin/test -vvct xx-potemplate-
== Demo and Q/A ==
Try these as a privileged and an unprivileged user. The link should be "Edit sharing details" and "View sharing details" respectively.
You will have to enable the feature:
translations.
View sharing information for a product series here:
http://
View sharing information for a template here:
http://
View sharing information for a pofile here:
http://
This will not show the link!
Once on the other side, you'll see the equivalent links there.
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
The exclamation mark in sharing- details- setup.png looks odd (now!). Links do not have punctuation. Why does this one need an exclamation mark? Launchpad does not have any links that say "now". This link looks like it wants to be a sentence. There are no links that use "Set up". I see "Set thing" and "Configure thing" I would expect this to be presented as
a sentence:
_(/) Configure sharing_ now!
or a navigational link
_(/) Configure sharing_