Launchpad itself

Merge lp:~henninge/launchpad/buildmaster-failure into lp:launchpad

  1. buildmaster-failure
  2. Merge into devel
Proposed by Henning Eggers on 2010-01-15
Status: Merged
Approved by: Henning Eggers on 2010-01-15
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~henninge/launchpad/buildmaster-failure
Merge into: lp:launchpad
Diff against target: 14 lines (+4/-0)
1 file modified
lib/lp/buildmaster/model/buildfarmjob.py (+4/-0)
To merge this branch: bzr merge lp:~henninge/launchpad/buildmaster-failure
Reviewer Review Type Date Requested Status
Michael Nelson (community) code 2010-01-15 Approve on 2010-01-15
Review via email: mp+17449@code.launchpad.net
To post a comment you must log in.
Henning Eggers (henninge) wrote :

Fixes the broken interface implementation in BuildFarmJob to get us out of the next testfix mode...

Michael Nelson (michael.nelson) wrote :

Thanks Henning!

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/buildmaster/model/buildfarmjob.py'
2--- lib/lp/buildmaster/model/buildfarmjob.py 2010-01-13 03:09:54 +0000
3+++ lib/lp/buildmaster/model/buildfarmjob.py 2010-01-15 09:59:12 +0000
4@@ -32,6 +32,10 @@
5 """See `IBuildFarmJob`."""
6 raise NotImplementedError
7
8+ def getTitle(self):
9+ """See `IBuildFarmJob`."""
10+ raise NotImplementedError
11+
12 def jobStarted(self):
13 """See `IBuildFarmJob`."""
14 pass