Merge lp:~henninge/launchpad/bug-612583-test-errors into lp:~launchpad/launchpad/recife

Proposed by Henning Eggers
Status: Merged
Approved by: Данило Шеган
Approved revision: no longer in the source branch.
Merged at revision: 9147
Proposed branch: lp:~henninge/launchpad/bug-612583-test-errors
Merge into: lp:~launchpad/launchpad/recife
Diff against target: 33 lines (+3/-2)
2 files modified
lib/lp/testing/__init__.py (+1/-0)
lib/lp/testing/factory.py (+2/-2)
To merge this branch: bzr merge lp:~henninge/launchpad/bug-612583-test-errors
Reviewer Review Type Date Requested Status
Данило Шеган (community) code Approve
Review via email: mp+31548@code.launchpad.net

Commit message

Fixed test errors after db-stable merge.

Description of the change

The bug 612583 failed to mention that these failures are related to a db-stable merge.

The KarmaRecorder was introduced in the recife branch. I don't know why is_published leaked into this again, but Hey!

To post a comment you must log in.
Revision history for this message
Данило Шеган (danilo) wrote :

Looks good, thanks.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/lp/testing/__init__.py'
2--- lib/lp/testing/__init__.py 2010-07-27 11:31:46 +0000
3+++ lib/lp/testing/__init__.py 2010-08-02 15:17:43 +0000
4@@ -115,6 +115,7 @@
5 from lp.testing._webservice import (
6 launchpadlib_credentials_for, launchpadlib_for, oauth_access_token_for)
7 from lp.testing.fixture import ZopeEventHandlerFixture
8+from lp.testing.karma import KarmaRecorder
9
10 # zope.exception demands more of frame objects than twisted.python.failure
11 # provides in its fake frames. This is enough to make it work with them
12
13=== modified file 'lib/lp/testing/factory.py'
14--- lib/lp/testing/factory.py 2010-07-27 11:31:46 +0000
15+++ lib/lp/testing/factory.py 2010-08-02 15:17:43 +0000
16@@ -2086,7 +2086,7 @@
17 sourcepackagename=None,
18 distroseries=None,
19 productseries=None, content=None,
20- uploader=None, is_published=False):
21+ uploader=None, from_upstream=False):
22 """Create a `TranslationImportQueueEntry`."""
23 if path is None:
24 path = self.getUniqueString() + '.pot'
25@@ -2116,7 +2116,7 @@
26 path=path, status=status, sourcepackagename=sourcepackagename,
27 distroseries=distroseries, productseries=productseries,
28 importer=uploader, content=content_reference,
29- is_published=is_published)
30+ from_upstream=from_upstream)
31
32 def makeMailingList(self, team, owner):
33 """Create a mailing list for the team."""

Subscribers

People subscribed via source and target branches