Merge lp:~henninge/launchpad/bug-510611-person-karma into lp:launchpad

[Henning Eggers]

Added page_title to PersonKarmaView.

[Henning Eggers (henninge)]

= Bug 510611 =

Mechanical change that must have been missed in the 3.0 rush.

== Test ==

bin/test -vvct karma

== Demo/QA ==

Look at your own karma page, verify it is headed "Your Launchpad Karma" and the bread crumbs end with just "Karma". Look at somebody else's karma page, it should be headed "Launchpad Karma for ..."

= Launchpad lint =

Tons in lib/lp/registry/browser/person.py but nothing on PersonKarmaView.

[Curtis Hovey (sinzui)]

Thanks for this fix.

review: Approve (code)

=== modified file 'lib/lp/registry/browser/person.py'
--- lib/lp/registry/browser/person.py	2010-01-11 20:07:17 +0000
+++ lib/lp/registry/browser/person.py	2010-01-29 14:03:19 +0000
@@ -2556,9 +2556,14 @@
 class PersonKarmaView(LaunchpadView):
     """A view class used for ~person/+karma."""
 
+    page_title = 'Karma'
+
     @property
     def label(self):
-        return 'Launchpad Karma for ' + cgi.escape(self.context.displayname)
+        if self.user == self.context:
+            return 'Your Launchpad Karma'
+        else:
+            return 'Launchpad Karma for %s' %  self.context.displayname
 
     @cachedproperty
     def has_karma(self):

=== modified file 'lib/lp/registry/browser/tests/person-karma-views.txt'
--- lib/lp/registry/browser/tests/person-karma-views.txt	2009-11-13 13:06:50 +0000
+++ lib/lp/registry/browser/tests/person-karma-views.txt	2010-01-29 14:03:19 +0000
@@ -11,7 +11,7 @@
 The view's label shows the person who's karma we're looking at...
 
     >>> print view.label
-    Launchpad Karma for Geddy Lee
+    Your Launchpad Karma
 
 ...even when the logged in user is looking at someone else's karma.
 

=== modified file 'lib/lp/registry/stories/person/xx-person-karma.txt'
--- lib/lp/registry/stories/person/xx-person-karma.txt	2009-09-18 15:24:30 +0000
+++ lib/lp/registry/stories/person/xx-person-karma.txt	2010-01-29 14:03:19 +0000
@@ -19,7 +19,7 @@
 
     >>> anon_browser.getLink('138').click()
     >>> print anon_browser.title
-    Launchpad Karma for Sample Person...
+    Karma : Sample Person
 
 Any user can see the categories that a user has earned karma in.