Merge lp:~henninge/launchpad/bug-456562 into lp:launchpad
Proposed by
Henning Eggers
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Данило Шеган | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~henninge/launchpad/bug-456562 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
334 lines 6 files modified
lib/lp/translations/doc/potmsgset.txt (+53/-8) lib/lp/translations/interfaces/potemplate.py (+7/-0) lib/lp/translations/interfaces/potmsgset.py (+24/-2) lib/lp/translations/model/potemplate.py (+18/-1) lib/lp/translations/model/potmsgset.py (+27/-5) lib/lp/translations/tests/test_potemplate.py (+13/-0) |
||||
To merge this branch: | bzr merge lp:~henninge/launchpad/bug-456562 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Данило Шеган (community) | Approve | ||
Review via email:
|
To post a comment you must log in.
= Details =
See bug 456562.
Added two methods to access translation credits messages. This is in preparation of solving bug 128324.
== Implementation details ==
I added a class attribute to POTMsgSet to export the list of possible msgids for translation credits. This is used in getTranslationC redits to build the query.
I added a parameter to updateTranslation because it guarded against changing translation credits. This can now be overridden by setting allow_credits to True.
== Test ==
bin/test -vvt potmsgset.txt -t getTranslationC redits
== Demo/QA ==
None yet as these methods are not used yet.