Merge ~hemanth-n/stsstack-bundles:nfs-server into stsstack-bundles:master

[Hemanth Nakkina]

Add nfs-server-test-fixture as overlay

[Edward Hope-Morley (hopem)]

Good feature. I think it would be good to add something in the way of a doc/docstring so that the uninitiated have an idea of how/when to use this.

[Hemanth Nakkina (hemanth-n)]

Updated the documentation as per Ed comments

review: Needs Resubmitting

diff --git a/doc/openstack/nfs-server.md b/doc/openstack/nfs-server.md
new file mode 100644
index 0000000..128ef2f
--- /dev/null
+++ b/doc/openstack/nfs-server.md
@@ -0,0 +1,31 @@
+# Deploying nfs-server
+
+The stsstack-bundles support deploying nfs-server as an overlay which can be
+used for the usecases where nfs server is required. Some of the use cases this
+will be helpful
+* cinder-backup configured to nfs backend [1]
+* deployment with trilio services [2] [3]
+
+Generate the cloud yaml via ./generate-bundle.sh adding --nfs-server overlay
+A new unit nfs-server-test-fixture/0 will be deployed which runs nfs-server.
+An additional disk of storage size 40 GB is attached to the unit.
+
+NFS export directory is configured at the path /srv/testing
+
+```
+# cat /etc/exports 
+# Test export with no permission restrictures
+/srv/testing *(rw,sync,no_root_squash)
+```
+
+The NFS Share mount path on the client side can be specified as
+<IP of nfs-server-test-fixture/0 unit>:/src/testing
+
+Example:
+```
+juju config trilio-wlm nfs-shares=10.5.1.170:/srv/testing
+```
+
+[1] https://docs.openstack.org/cinder/latest/configuration/block-storage/backup/nfs-backup-driver.html
+[2] https://jaas.ai/u/openstack-charmers/trilio-wlm/3#charm-config-nfs-shares
+[3] https://jaas.ai/u/openstack-charmers/trilio-data-mover/2#charm-config-nfs-shares
diff --git a/openstack/pipeline/02configure b/openstack/pipeline/02configure
index 05a8057..80745f8 100644
--- a/openstack/pipeline/02configure
+++ b/openstack/pipeline/02configure
@@ -284,6 +284,9 @@ do
             MOD_OVERLAYS+=( "nova-console.yaml" )
             get_param $1 __CONSOLE_TYPE__ "REQUIRES: nova console access protocol:"
             ;;
+        --nfs-server)
+            MOD_OVERLAYS+=("nfs-server-test-fixture.yaml")
+	    ;;
         --octavia)
             if `has_opt --ovn`; then
                 assert_min_release train "octavia+ovn"
diff --git a/overlays/nfs-server-test-fixture.yaml b/overlays/nfs-server-test-fixture.yaml
new file mode 100644
index 0000000..b6eabd4
--- /dev/null
+++ b/overlays/nfs-server-test-fixture.yaml
@@ -0,0 +1,6 @@
+applications:
+  nfs-server-test-fixture:
+    charm: cs:~openstack-charmers-next/nfs-server-test-fixture
+    num_units: 1
+    storage:
+      share: cinder,40G