Merge ~hemanth-n/charm-grafana:1829368 into charm-grafana:master

Proposed by Hemanth Nakkina
Status: Merged
Approved by: Jeremy Lounder
Approved revision: f8a3046484292f838fb8f8e135cd0abf3ce39611
Merged at revision: 20436922f132302ef378e2a7b952444aec19b496
Proposed branch: ~hemanth-n/charm-grafana:1829368
Merge into: charm-grafana:master
Diff against target: 13 lines (+2/-0)
1 file modified
reactive/grafana.py (+2/-0)
Reviewer Review Type Date Requested Status
Jeremy Lounder (community) Approve
Edward Hope-Morley (community) Approve
Seyeong Kim (community) Approve
Hemanth Nakkina (community) Needs Resubmitting
Canonical IS Reviewers Pending
Review via email: mp+375999@code.launchpad.net

Commit message

Add grafana service enable on boot

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Seyeong Kim (seyeongkim) wrote :

Hello

I would rather add "enable" call on install function.
I've just checked the other charm and it calls "enable" call when installing it.

rather than changing "start" to "resume"

Thanks

Revision history for this message
Hemanth Nakkina (hemanth-n) wrote :

Seyeong, submitted new patch with your recommendation. Please review.

review: Needs Resubmitting
Revision history for this message
Seyeong Kim (seyeongkim) wrote :

+1

LGTM

review: Approve
Revision history for this message
Edward Hope-Morley (hopem) :
review: Approve
Revision history for this message
Jeremy Lounder (jldev) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 20436922f132302ef378e2a7b952444aec19b496

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reactive/grafana.py b/reactive/grafana.py
2index 01bfcda..e1dc444 100644
3--- a/reactive/grafana.py
4+++ b/reactive/grafana.py
5@@ -114,6 +114,8 @@ def install_packages():
6 packages = ['grafana']
7 fetch.configure_sources(update=True)
8 fetch.apt_install(packages, fatal=True)
9+ svcname = SVCNAME[source]
10+ host.service('enable', svcname)
11 set_state('grafana.installed')
12 hookenv.status_set('active', 'Completed installing grafana')
13 elif source == 'snap' and \

Subscribers

People subscribed via source and target branches

to all changes: