Merge lp:~hegarty-sam/midori/midori-inline-speeddialtitle into lp:midori
Proposed by
Sam Hegarty
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | lp:~hegarty-sam/midori/midori-inline-speeddialtitle | ||||
Merge into: | lp:midori | ||||
Diff against target: |
162 lines (+62/-14) 2 files modified
data/speeddial-head.html (+61/-12) midori/midori-speeddial.vala (+1/-2) |
||||
To merge this branch: | bzr merge lp:~hegarty-sam/midori/midori-inline-speeddialtitle | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sam Hegarty (community) | Needs Resubmitting | ||
Paweł Forysiuk | Needs Fixing | ||
Danielle Foré (community) | Needs Fixing | ||
Review via email:
|
This proposal has been superseded by a proposal from 2014-11-08.
Description of the change
Change how the user edits the title of shortcuts on the speed dial so instead of a prompt displaying it's done inline.
To post a comment you must log in.
Is there a reason for changing the indentation on diffline 9?
needs a space after the : on diffline 17
Maybe use "transparent" instead of "rgba(0, 0, 0, 0)"
I can confirm that this fixes the issue :)