Merge ~hectorcao/ubuntu/+source/paramiko:merge-lp2066061 into ubuntu/+source/paramiko:debian/sid

Proposed by Hector CAO
Status: Merged
Merge reported by: Hector CAO
Merged at revision: a8dc0e056f0620535d313bbe4901957a120568c2
Proposed branch: ~hectorcao/ubuntu/+source/paramiko:merge-lp2066061
Merge into: ubuntu/+source/paramiko:debian/sid
Diff against target: 225 lines (+140/-3)
4 files modified
debian/changelog (+121/-0)
debian/control (+3/-3)
debian/patches/disable_flaky_test.patch (+15/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
Marc Deslauriers (community) Approve
Canonical Server Reporter Pending
git-ubuntu import Pending
Review via email: mp+466111@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Looks good. Could you just fix the spacing in the changelog? Some lines have too much indentation, and one of the lines is too long. So changing it to something like this would do:

+ - d/control: Demote python3-invoke from Recommends to Suggests as
+ the python-invoke package lacks unit test execution so is not suitable
+ for main inclusion
+ - debian/patches/disable_flaky_test.patch: disable flaky
+ test_sequence_numbers_reset_on_newkeys_when_strict test.

review: Needs Fixing
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Oh, that broke. Basically the "t" in "the" should be underneath the "d" in "d/control", etc.

Revision history for this message
Hector CAO (hectorcao) wrote :

> Oh, that broke. Basically the "t" in "the" should be underneath the "d" in
> "d/control", etc.

Thanks @mdeslaur, fixed.

Revision history for this message
Hector CAO (hectorcao) wrote :

> Looks good. Could you just fix the spacing in the changelog? Some lines have
> too much indentation, and one of the lines is too long. So changing it to
> something like this would do:
>
> + - d/control: Demote python3-invoke from Recommends to Suggests as
> + the python-invoke package lacks unit test execution so is not
> suitable
> + for main inclusion
> + - debian/patches/disable_flaky_test.patch: disable flaky
> + test_sequence_numbers_reset_on_newkeys_when_strict test.

Thanks @mdeslaur, fixed.

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

ack, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 84ff552..aad1a0d 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,23 @@
6+paramiko (3.4.0-1ubuntu1) oracular; urgency=medium
7+
8+ * Merge with Debian unstable. Remaining changes (LP: #2066061):
9+ - d/control: Demote python3-invoke from Recommends to Suggests as
10+ the python-invoke package lacks unit test execution so is not suitable
11+ for main inclusion
12+ - debian/patches/disable_flaky_test.patch: disable flaky
13+ test_sequence_numbers_reset_on_newkeys_when_strict test.
14+ Dropped changes:
15+ - SECURITY UPDATE: Prefix truncation attack on BPP
16+ - debian/patches/CVE-2023-48795-*.patch: implement strict key
17+ exchange.
18+ - CVE-2023-48795
19+ Dropped because these patches are applied upstream
20+ - debian/patches/remove_six.patch : removed because already upstreamed
21+ - debian/patches/fix_test_on_armhf.patch : removed because not applicable
22+ since the tests/test_transport.py has been changed upstreamed
23+
24+ -- Hector Cao <hector.cao@canonical.com> Fri, 17 May 2024 19:12:44 +0200
25+
26 paramiko (3.4.0-1) unstable; urgency=medium
27
28 * Team upload
29@@ -20,6 +40,38 @@ paramiko (2.12.0-3) unstable; urgency=medium
30
31 -- Sandro Tosi <morph@debian.org> Wed, 28 Feb 2024 01:25:38 -0500
32
33+paramiko (2.12.0-2ubuntu4) noble; urgency=medium
34+
35+ * debian/patches/fix_test_on_armhf.patch: fix test failing on armhf.
36+ * debian/patches/disable_flaky_test.patch: disable flaky
37+ test_sequence_numbers_reset_on_newkeys_when_strict test.
38+
39+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Wed, 24 Jan 2024 09:18:51 -0500
40+
41+paramiko (2.12.0-2ubuntu3) noble; urgency=medium
42+
43+ * debian/patches/remove_six.patch: remove last use of six to fix FTBFS.
44+
45+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Fri, 12 Jan 2024 10:11:46 -0500
46+
47+paramiko (2.12.0-2ubuntu2) noble; urgency=medium
48+
49+ * SECURITY UPDATE: Prefix truncation attack on BPP
50+ - debian/patches/CVE-2023-48795-*.patch: implement strict key
51+ exchange.
52+ - CVE-2023-48795
53+
54+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Thu, 11 Jan 2024 08:56:18 -0500
55+
56+paramiko (2.12.0-2ubuntu1) lunar; urgency=medium
57+
58+ * Merge from Debian unstable, remaining changes:
59+ + d/control: Demote python3-invoke from Recommends to Suggests as
60+ the python-invoke package lacks unit test execution so is not suitable
61+ for main inclusion
62+
63+ -- Graham Inggs <ginggs@ubuntu.com> Fri, 17 Feb 2023 09:35:50 +0000
64+
65 paramiko (2.12.0-2) unstable; urgency=medium
66
67 * Run autopkgtests via autopkgtest-pkg-pybuild
68@@ -38,6 +90,15 @@ paramiko (2.12.0-1) unstable; urgency=medium
69
70 -- Sandro Tosi <morph@debian.org> Sat, 17 Dec 2022 14:09:43 -0500
71
72+paramiko (2.10.4-1ubuntu1) kinetic; urgency=low
73+
74+ * Merge from Debian unstable. Remaining changes:
75+ - d/control: Demote python3-invoke from Recommends to Suggests as
76+ the python-invoke package lacks unit test execution so is not suitable
77+ for main inclusion.
78+
79+ -- Benjamin Drung <bdrung@ubuntu.com> Mon, 16 May 2022 17:12:00 +0200
80+
81 paramiko (2.10.4-1) unstable; urgency=medium
82
83 * Team upload.
84@@ -64,6 +125,40 @@ paramiko (2.10.3-1) unstable; urgency=medium
85
86 -- Benjamin Drung <bdrung@ubuntu.com> Tue, 12 Apr 2022 16:40:12 +0200
87
88+paramiko (2.9.3-0ubuntu1) jammy; urgency=medium
89+
90+ * New upstream release (LP: #1968730).
91+ - Add support for SHA-2 variants of RSA key verification algorithms
92+ to support openssh >= 8.8p1-1 (Closes: #1007168, LP: #1961979)
93+ * Refresh patches.
94+
95+ -- Benjamin Drung <bdrung@ubuntu.com> Tue, 12 Apr 2022 16:26:58 +0200
96+
97+paramiko (2.8.1-1ubuntu3) jammy; urgency=medium
98+
99+ * SECURITY UPDATE: race condition in write_private_key_file
100+ - debian/patches/CVE-2022-24302.patch: create file with proper
101+ permissions in paramiko/pkey.py, tests/test_pkey.py.
102+ - CVE-2022-24302
103+
104+ -- Marc Deslauriers <marc.deslauriers@ubuntu.com> Thu, 24 Mar 2022 09:21:29 -0400
105+
106+paramiko (2.8.1-1ubuntu2) jammy; urgency=medium
107+
108+ * d/p/thread-setdaemon-deprecation.patch: patch out a deprecation warning
109+ with Python 3.10 (LP: #1959095)
110+
111+ -- Simon Chopin <simon.chopin@canonical.com> Wed, 26 Jan 2022 11:35:18 +0100
112+
113+paramiko (2.8.1-1ubuntu1) jammy; urgency=low
114+
115+ * Merge from Debian unstable. Remaining changes:
116+ - d/control: Demote python3-invoke from Recommends to Suggests as
117+ the python-invoke package lacks unit test execution so is not suitable
118+ for main inclusion.
119+
120+ -- James Page <james.page@ubuntu.com> Fri, 17 Dec 2021 10:35:06 +0000
121+
122 paramiko (2.8.1-1) unstable; urgency=medium
123
124 * New upstream release
125@@ -76,6 +171,15 @@ paramiko (2.8.1-1) unstable; urgency=medium
126
127 -- Sandro Tosi <morph@debian.org> Sat, 11 Dec 2021 01:27:04 -0500
128
129+paramiko (2.8.0-1ubuntu1) jammy; urgency=low
130+
131+ * Merge from Debian unstable. Remaining changes:
132+ - d/control: Demote python3-invoke from Recommends to Suggests as
133+ the python-invoke package lacks unit test execution so is not suitable
134+ for main inclusion.
135+
136+ -- James Page <james.page@ubuntu.com> Wed, 27 Oct 2021 16:18:44 +0100
137+
138 paramiko (2.8.0-1) unstable; urgency=medium
139
140 [ Ondřej Nový ]
141@@ -95,6 +199,15 @@ paramiko (2.8.0-1) unstable; urgency=medium
142
143 -- Sandro Tosi <morph@debian.org> Fri, 15 Oct 2021 13:33:52 -0400
144
145+paramiko (2.7.2-1ubuntu1) hirsute; urgency=low
146+
147+ * Merge from Debian unstable. Remaining changes:
148+ - d/control: Demote python3-invoke from Recommends to Suggests as
149+ the python-invoke package lacks unit test execution so is not suitable
150+ for main inclusion.
151+
152+ -- James Page <james.page@ubuntu.com> Thu, 29 Oct 2020 14:34:26 +0000
153+
154 paramiko (2.7.2-1) unstable; urgency=medium
155
156 * Team upload.
157@@ -106,6 +219,14 @@ paramiko (2.7.2-1) unstable; urgency=medium
158
159 -- Tristan Seligmann <mithrandi@debian.org> Wed, 02 Sep 2020 10:33:40 +0200
160
161+paramiko (2.7.1-2ubuntu1) groovy; urgency=medium
162+
163+ * d/control: Demote python3-invoke from Recommends to Suggests as
164+ the python-invoke package lacks unit test execution so is not suitable
165+ for main inclusion (LP: #1892875).
166+
167+ -- James Page <james.page@ubuntu.com> Thu, 03 Sep 2020 09:40:05 +0100
168+
169 paramiko (2.7.1-2) unstable; urgency=medium
170
171 * debian/rules
172diff --git a/debian/control b/debian/control
173index 856b088..15728fc 100644
174--- a/debian/control
175+++ b/debian/control
176@@ -1,7 +1,8 @@
177 Source: paramiko
178 Section: python
179 Priority: optional
180-Maintainer: Debian Python Team <team+python@tracker.debian.org>
181+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
182+XSBC-Original-Maintainer: Debian Python Team <team+python@tracker.debian.org>
183 Uploaders: Jeremy T. Bouse <jbouse@debian.org>,
184 Guido Guenther <agx@debian.org>,
185 Santiago Ruano Rincón <santiagorr@riseup.net>,
186@@ -49,8 +50,7 @@ Architecture: all
187 Depends: ${misc:Depends},
188 ${python3:Depends},
189 Provides: ${python3:Provides},
190-Recommends: python3-invoke,
191-Suggests: python3-gssapi (>= 0.6.1),
192+Suggests: python3-gssapi (>= 0.6.1), python3-invoke
193 Description: Make ssh v2 connections (Python 3)
194 "Paramiko" is a combination of the Esperanto words for "paranoid" and "friend".
195 It's a module for Python 2.7/3.4+ that implements the SSH2 protocol for secure
196diff --git a/debian/patches/disable_flaky_test.patch b/debian/patches/disable_flaky_test.patch
197new file mode 100644
198index 0000000..a815ed1
199--- /dev/null
200+++ b/debian/patches/disable_flaky_test.patch
201@@ -0,0 +1,15 @@
202+Description: disable flaky test
203+Author: Marc Deslauriers <marc.deslauriers@canonical.com>
204+
205+--- a/tests/test_transport.py
206++++ b/tests/test_transport.py
207+@@ -1633,7 +1633,8 @@ class TestStrictKex:
208+ ):
209+ pass # kexinit happens at connect...
210+
211+- def test_sequence_numbers_reset_on_newkeys_when_strict(self):
212++ # This test is disabled as it is flaky
213++ def disabled_test_sequence_numbers_reset_on_newkeys_when_strict(self):
214+ with server(defer=True) as (tc, ts):
215+ # When in strict mode, these should all be zero or close to it
216+ # (post-kexinit, pre-auth).
217diff --git a/debian/patches/series b/debian/patches/series
218index 0e6becc..ee37bf0 100644
219--- a/debian/patches/series
220+++ b/debian/patches/series
221@@ -1,3 +1,4 @@
222 remove_pytest_relaxed.patch
223 0001-Use-pytest-s-setup_method-in-pytest-8-the-nose-metho.patch
224 0001-Fix-32-bit-ism-in-protocol-seqno-rollover-test-from-.patch
225+disable_flaky_test.patch

Subscribers

People subscribed via source and target branches