Merge ~hectorcao/ubuntu/+source/crmsh:lp2139102 into ubuntu/+source/crmsh:ubuntu/devel

[Hector CAO]

[Christian Ehrhardt (paelzer)]

- please report upstream and refer to it in dep3 headers

- please fix this for Str and Num, use the pattern they already established for Constant when handling potentially existing elements

Something like

Remove the two lines about Num and Str

# py3.14 completely dropped ast.Num and ast.Str - https://docs.python.org/3/whatsnew/3.14.html#id9
        if hasattr(ast, 'Num'):
            self.nodes[ast.Num] = self._eval_num
        if hasattr(ast, 'Str'):
            self.nodes[ast.Str] = self._eval_str

- commit message "changelog" could be nicer, maybe "changelog for 5.0.0-2ubuntu2"

review: Needs Fixing

[Hector CAO (hectorcao)]

Thanks Christian for the review,

- I reported the bug upstream + MR
- I refreshed the Ubuntu patch based on the MR upstream
- I improved the changelog commit message

Please let me know what you think,

[Christian Ehrhardt (paelzer)]

Thanks for the changes, approved and uploading

review: Approve

[Christian Ehrhardt (paelzer)]

Uploading crmsh_5.0.0-2ubuntu2.dsc
Uploading crmsh_5.0.0-2ubuntu2.debian.tar.xz
Uploading crmsh_5.0.0-2ubuntu2_source.buildinfo
Uploading crmsh_5.0.0-2ubuntu2_source.changes

diff --git a/debian/changelog b/debian/changelog
index 4dc8bf9..a933d9e 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+crmsh (5.0.0-2ubuntu2) resolute; urgency=medium
+
+  * d/p/0028-* : Replace ast.Num by ast.Constant for Python 3.14
+    (LP: #2139102)
+
+ -- Hector Cao <[e-mail]>  Mon, 02 Feb 2026 16:57:08 +0100
+
 crmsh (5.0.0-2ubuntu1) resolute; urgency=medium
 
   * Merge with Debian unstable (LP: #2125991). Remaining changes:
diff --git a/debian/patches/0028-minieval.py-Use-ast.Constant-instead-of-ast.Num.patch b/debian/patches/0028-minieval.py-Use-ast.Constant-instead-of-ast.Num.patch
new file mode 100644
index 0000000..c0b666b
--- /dev/null
+++ b/debian/patches/0028-minieval.py-Use-ast.Constant-instead-of-ast.Num.patch
@@ -0,0 +1,48 @@
+Description: minieval.py : remove ast.Num and ast.Str
+
+ Python 3.14 now removes ast.Num and ast.Str in favor
+ of ast.Constant.
+
+Forwarded: https://github.com/ClusterLabs/crmsh/pull/2028
+Author: Hector CAO <[e-mail]>
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/2139102
+Last-Update: 2026-02-09
+
+---
+ crmsh/minieval.py | 13 ++++++++-----
+ 1 file changed, 8 insertions(+), 5 deletions(-)
+
+diff --git a/crmsh/minieval.py b/crmsh/minieval.py
+index 06e780c2..af9cde04 100644
+--- a/crmsh/minieval.py
++++ b/crmsh/minieval.py
+@@ -183,8 +183,7 @@ class SimpleEval(object):  # pylint: disable=too-few-public-methods
+         self.names = names
+ 
+         self.nodes = {
+-            ast.Num: self._eval_num,
+-            ast.Str: self._eval_str,
++            ast.Constant: self._eval_constant,
+             ast.Name: self._eval_name,
+             ast.UnaryOp: self._eval_unaryop,
+             ast.BinOp: self._eval_binop,
+@@ -204,9 +203,13 @@ class SimpleEval(object):  # pylint: disable=too-few-public-methods
+         elif isinstance(self.names, dict) and "None" not in self.names:
+             self.names["None"] = None
+ 
+-        # py3.8 uses ast.Constant instead of ast.Num, ast.Str, ast.NameConstant
+-        if hasattr(ast, 'Constant'):
+-            self.nodes[ast.Constant] = self._eval_constant
++        # py3.14 completely dropped ast.Num and ast.Str
++        # in favor of ast.Constant that encodes different types of value
++        # See https://docs.python.org/3/whatsnew/3.14.html#id9
++        if hasattr(ast, 'Str'):
++            self.nodes[ast.Str] = self._eval_str
++        if hasattr(ast, 'Num'):
++            self.nodes[ast.Num] = self._eval_num
+ 
+     def evaluate(self, expr):
+         """ evaluate an expresssion, using the operators, functions and
+-- 
+2.34.1
+
diff --git a/debian/patches/series b/debian/patches/series
index 74a5afc..8782319 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -14,3 +14,4 @@
 0025-Fix_doc_build.patch
 0026-Fix_python_build.patch
 0027-Rename_sbd_config.patch
+0028-minieval.py-Use-ast.Constant-instead-of-ast.Num.patch