ubuntu-server-iso-testing

Merge lp:~heber013/ubuntu-server-iso-testing/fixing-url-format into lp:ubuntu-server-iso-testing

  1. fixing-url-format
  2. Merge into trunk
Proposed by Heber Parrucci
Status: Merged
Approved by: Joshua Powers
Approved revision: 273
Merged at revision: 273
Proposed branch: lp:~heber013/ubuntu-server-iso-testing/fixing-url-format
Merge into: lp:ubuntu-server-iso-testing
Diff against target: 18 lines (+3/-3)
1 file modified
download-latest-test-iso.py (+3/-3)
To merge this branch: bzr merge lp:~heber013/ubuntu-server-iso-testing/fixing-url-format
Reviewer Review Type Date Requested Status
Joshua Powers (community) Approve
Review via email: mp+358251@code.launchpad.net

Commit message

Fixing the URL format from {base_url}/{release}/{flavor} to {base_url}/{flavor}/{release}

Description of the change

When you specify a flavor other than ubuntu, for example kubuntu, ubuntu-mate, etc. The URL is not found when checking the sha256 due to an invalid format.
I changed it from:

{base_url}/{release}/{flavor} to {base_url}/{flavor}/{release}/

To test it, you can run for example:

python2 -m download-latest-test-iso -r bionic -v desktop -a amd64 -b pending -i ~/isos -f ubuntu-mate

To post a comment you must log in.
Revision history for this message
Joshua Powers (powersj) wrote :

LGTM appears to only touch desktop and the ubuntu case is covered with a default; so +1 I'll merge shortly

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'download-latest-test-iso.py'
2--- download-latest-test-iso.py 2018-11-01 19:27:41 +0000
3+++ download-latest-test-iso.py 2018-11-02 19:19:51 +0000
4@@ -155,11 +155,11 @@
5 if options.flavor == 'ubuntu':
6 flavor_part = ''
7 if options.variant == 'desktop':
8- l_url = os.path.join(options.base_url, release_part, flavor_part, 'daily-live')
9+ l_url = os.path.join(options.base_url, flavor_part, release_part, 'daily-live')
10 elif options.variant == 'alternate':
11- l_url = os.path.join(options.base_url, release_part, flavor_part, 'daily')
12+ l_url = os.path.join(options.base_url, flavor_part, release_part, 'daily')
13 elif options.variant == 'dvd':
14- l_url = os.path.join(options.base_url, release_part, flavor_part, 'dvd')
15+ l_url = os.path.join(options.base_url, flavor_part, release_part, 'dvd')
16 elif options.variant == 'live-server':
17 l_url = os.path.join(options.base_url, 'ubuntu-server',release_part,
18 'daily-live')

Subscribers

People subscribed via source and target branches