Merge lp:~heber013/ubuntu-server-iso-testing/fixing-default-distro-error into lp:ubuntu-server-iso-testing

Proposed by Heber Parrucci
Status: Merged
Approved by: Joshua Powers
Approved revision: 272
Merged at revision: 272
Proposed branch: lp:~heber013/ubuntu-server-iso-testing/fixing-default-distro-error
Merge into: lp:ubuntu-server-iso-testing
Diff against target: 12 lines (+1/-1)
1 file modified
download-latest-test-iso.py (+1/-1)
To merge this branch: bzr merge lp:~heber013/ubuntu-server-iso-testing/fixing-default-distro-error
Reviewer Review Type Date Requested Status
Joshua Powers (community) Approve
Review via email: mp+358192@code.launchpad.net

Commit message

Adding exception when calculating default distro

Description of the change

Currently the jobs that downloads the isos are failing at:

Traceback (most recent call last):
  File "/usr/bin/download-latest-test-iso", line 35, in <module>
    DEFAULT_RELEASE = distro_info.UbuntuDistroInfo().devel()
  File "/usr/lib/python2.7/dist-packages/distro_info.py", line 96, in devel
    raise DistroDataOutdated()
distro_info.DistroDataOutdated: Distribution data outdated. Please check for an update for distro-info-data. See /usr/share/doc/distro-info-data/README.Debian for details.

I added an exception so when it raises, the default variable is assigned and the script continues.

To post a comment you must log in.
Revision history for this message
Joshua Powers (powersj) wrote :

LGTM thanks for cleaning this up.

review: Approve
Revision history for this message
Heber Parrucci (heber013) wrote :

> LGTM thanks for cleaning this up.

Thanks! Can you push it to lp:ubuntu-server-iso-testing? It seems that I do not have permissions to do that.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'download-latest-test-iso.py'
2--- download-latest-test-iso.py 2018-02-13 17:21:03 +0000
3+++ download-latest-test-iso.py 2018-11-01 19:35:09 +0000
4@@ -33,7 +33,7 @@
5 try:
6 import distro_info
7 DEFAULT_RELEASE = distro_info.UbuntuDistroInfo().devel()
8-except ImportError:
9+except (ImportError, distro_info.DistroDataOutdated):
10 DEFAULT_RELEASE = 'trusty'
11
12 DEFAULT_ARCH = 'all'

Subscribers

People subscribed via source and target branches