Merge lp:~hduran-8/juju-ci-tools/add_storage_ci_tests into lp:juju-ci-tools

[Horacio Durán]

Add storage CI tests.

Tests for Storage, they deploy the storagetest charm and then check that rootfs storage is mounted (by checking existence of the file storagetest writes upon attachment) and, if the strate is supported it also tests that platform specific storage has been attached.

[lp:~hduran-8/juju-ci-tools/add_storage_ci_tests]

984. By Horacio Durán on 2015-06-24

Fixed typo in storage test

985. By Horacio Durán on 2015-07-10

Merged changes from status branch.

986. By Horacio Durán on 2015-07-23

Merged the tests with trunk

Unmerged revisions

986. By Horacio Durán on 2015-07-23

Merged the tests with trunk

985. By Horacio Durán on 2015-07-10

Merged changes from status branch.

984. By Horacio Durán on 2015-06-24

Fixed typo in storage test

983. By Horacio Durán on 2015-06-24

Corrected lint issues

982. By Horacio Durán on 2015-06-24

Added tests for storage

=== added file 'assess_storage.py'
--- assess_storage.py	1970-01-01 00:00:00 +0000
+++ assess_storage.py	2015-07-23 23:59:06 +0000
@@ -0,0 +1,106 @@
+#!/usr/bin/python
+from __future__ import print_function
+
+__metaclass__ = type
+
+from os import remove as osremove
+from os.path import (
+    join as pjoin,
+    isdir as pisdir,
+    isfile as pisfile
+)
+from shutil import rmtree
+from tempfile import mkdtemp
+
+from argparse import ArgumentParser
+from utility import add_basic_testing_arguments
+from jujupy import (
+    make_client,
+)
+from utility import (
+    print_now,
+)
+from deploy_stack import (
+    boot_context,
+    prepare_environment,
+)
+
+
+def parse_args():
+    """Parse all arguments."""
+    parser = ArgumentParser('Test storage attachment')
+    add_basic_testing_arguments(parser)
+    return parser.parse_args()
+
+
+def main():
+    args = parse_args()
+    log_dir = args.logs
+
+    client = make_client(
+        args.juju_path, args.debug, args.env, args.temp_env_name)
+    # a list of folders to be cleaned up
+    to_delete = []
+
+    series = args.series
+    if series is None:
+        series = 'precise'
+    with boot_context(args.job_name, client, args.bootstrap_host,
+                      args.machine, series, args.agent_url, args.agent_stream,
+                      log_dir, args.keep_env, args.upload_tools):
+        prepare_environment(
+            client, already_bootstrapped=True, machines=args.machine)
+
+        client.get_status(60)
+        env_type = client.env.config['type']
+        if env_type == "ec2":
+            client.juju("deploy", ('local:trusty/storagetest',
+                                   '--storage', 'testnativefs=ebs,1G'))
+        elif env_type == "maas":
+            client.juju("deploy", ('local:trusty/storagetest',
+                                   '--storage', 'testnativefs=maas,1G'))
+        elif env_type == "openstack":
+            client.juju("deploy", ('local:trusty/storagetest',
+                                   '--storage', 'testnativefs=cinder,1G'))
+        else:
+            print_now("there is no native storage for this substrate")
+
+        # Wait for the deployment to finish.
+        client.wait_for_started()
+
+        # At this point you have a juju bootstraped with a wordpress charm
+        # deployed and active with the agent idle.
+        test_storage(to_delete, client, "/mnt/testrootfs")
+        if env_type in ("ec2", "maas", "openstack"):
+            test_storage(to_delete, client, "/mnt/testnativefs")
+
+    for deletable in to_delete:
+        try:
+            if pisdir(deletable):
+                rmtree(deletable)
+            elif pisfile(deletable):
+                osremove(deletable)
+            else:
+                raise Exception("Is not a file or directory")
+        except Exception, e:
+            print_now("cannot delete %s: %s" % [deletable, e])
+
+PROOF = "This text is the proof that storage-attached hook ran with"\
+        " filesystem storage"
+
+
+def test_storage(to_delete, client, mountpoint):
+    tdir = mkdtemp()
+    to_delete.append(tdir)
+    client.juju("scp", ("--",
+                        "storagetest/0:%s/proof.txt" % mountpoint,
+                        tdir))
+    with open(pjoin(tdir, "proof.txt"), "r") as proof:
+        lines = proof.readlines()
+        assert len(lines) == 1, "the proof file should have 1 line only"
+        line = lines[0]
+        assert line == PROOF, "The text is not the expected: %s" % line
+
+
+if __name__ == '__main__':
+    main()

=== added file 'test_assess_storage.py'
--- test_assess_storage.py	1970-01-01 00:00:00 +0000
+++ test_assess_storage.py	2015-07-23 23:59:06 +0000
@@ -0,0 +1,69 @@
+__metaclass__ = type
+
+from os.path import (
+    join as pjoin,
+    isdir as pisdir,
+    isfile as pisfile
+)
+
+from os import remove as osremove
+from shutil import rmtree, copy
+from tempfile import mkdtemp
+
+from assess_storage import (
+    PROOF,
+    test_storage
+)
+
+from unittest import TestCase
+
+
+class FakeClient:
+    def __init__(self, check=lambda x, y: None):
+        self.command = ""
+        self.command_args = ""
+        self.check = check
+
+    def juju(self, command, command_args):
+        self.command = command
+        self.command_args = command_args
+        self.check(command, command_args)
+
+
+class TestStorageTester(TestCase):
+
+    def test_proof_is_there(self):
+        to_delete = []
+        try:
+            tdir = mkdtemp()
+            pfile = pjoin(tdir, "proof.txt")
+
+            with open(pfile, "w") as proof:
+                proof.write(PROOF)
+
+            def check_scp(command, command_args):
+                self.assertEqual(command, "scp")
+                self.assertEqual(len(command_args), 3)
+                self.assertEqual(command_args[0], "--")
+                self.assertIn("/a/mount/point/proof.txt", command_args[1])
+                self.assertTrue(pisdir(command_args[2]))
+                copy(pfile, command_args[2])
+            client = FakeClient(check_scp)
+            test_storage(to_delete, client, "/a/mount/point")
+            self.assertTrue(len(to_delete) == 1)
+            self.assertTrue(pisdir(to_delete[0]))
+            self.assertTrue(pisfile(pjoin(to_delete[0], "proof.txt")))
+        except Exception, e:
+            raise e
+        finally:
+            rmtree(mkdtemp())
+            for deletable in to_delete:
+                    try:
+                        if pisdir(deletable):
+                            rmtree(deletable)
+                        elif pisfile(deletable):
+                            osremove(deletable)
+                        else:
+                            raise Exception("Is not a file or directory")
+                    except Exception, e:
+                        print("cannot delete %s: %s" % [deletable, e])