lp:~hduran-8/goose/testservice_errors

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:goose at revision 121

Juju Engineering: Pending requested 2014-04-30

Diff: 681 lines (+223/-58)

5 files modified

testservices/errors.go (+137/-0)
testservices/errors_test.go (+29/-0)
testservices/novaservice/service.go (+21/-21)
testservices/novaservice/service_test.go (+33/-33)
testservices/service.go (+3/-4)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

124. By Horacio Durán on 2014-04-30

Added comment referencing the origin of the error map

123. By Horacio Durán on 2014-04-30

Go formatted

122. By Horacio Durán on 2014-04-30

Simplified code as per axw suggestion

121. By Horacio Durán on 2014-04-30

Passed though go fmt

120. By Horacio Durán on 2014-04-30

Added proper error types for each error

119. By Andrew Wilkins on 2014-04-23

[r=axwalk] http: close response body if unused

BinaryRequest calls may discard the response
without closing it. This was causing sockets
to be left open in juju-core/provider/openstack
tests, leading to test failures.

https://codereview.appspot.com/90540043/

118. By John A Meinel on 2014-03-07

[r=jameinel],[bug=1226996] panic if we get bad requests

It turns out that if you don't supply CIDR or GroupId Openstack just
sets CIDR to 0.0.0.0/0. We don't want to rely on that behavior, so
this just changes the goose test double to panic if it got that
situation.

This can't land until we land my updated Juju branch (or the test
suite will appropriately fail with panic().)

https://codereview.appspot.com/13781043/

117. By Dave Cheney on 2014-02-06

[r=dave-cheney] Make test pass on gccgo 4.8

gccgo 4.8 and 4.9 have a different view on the number of callers on the call stack.

Attempt to detect the correct value automatically.

116. By Martin Packman on 2014-01-24

[r=gz] Add networks attribute to RunServer params

This enables the starting of a server on a specific
network, which is required for some situations where
multiple networks exist.

This is not well tested at present, to do a proper job some
more network related operations need to be added so the
tests can do real operations.

https://codereview.appspot.com/56670043/

R=natefinch

115. By Martin Packman on 2014-01-20

[r=gz] Add support for network listing api call

Lists networks using the os-networks extension, which may backend
onto either neutron or nova-network. This should provide a baseline
of support even where the neutron api is not available.

Goose doesn't yet support detecting if a given extension is supported,
that would be nice here as we'll want to know which of neutron,
os-networks, and os-tenant-networks are usable.

https://codereview.appspot.com/50630044/

R=dimitern