Code review comment for lp:~hduran-8/goose/json_encoded_errors

Revision history for this message
Martin Packman (gz) wrote :

LGTM.

https://codereview.appspot.com/97870044/diff/20001/http/client.go
File http/client.go (right):

https://codereview.appspot.com/97870044/diff/20001/http/client.go#newcode62
http/client.go:62: return nil, err
We seem to not be able to hit this error branch, that's fine.

https://codereview.appspot.com/97870044/diff/20001/http/client.go#newcode64
http/client.go:64: response.Title = key
Add break here. May as well exit early if we're passed something with
many top level keys.

https://codereview.appspot.com/97870044/diff/20001/http/client.go#newcode69
http/client.go:69: return nil, fmt.Errorf("Unexpected response format:
%q", jsonBytes)
"Unparsable json error body"

https://codereview.appspot.com/97870044/diff/20001/http/client_test.go
File http/client_test.go (right):

https://codereview.appspot.com/97870044/diff/20001/http/client_test.go#newcode191
http/client_test.go:191: c.Assert(unmarshalled.Message, Equals, "A
Meaningful error")
These attribute compares should be Check not Assert.

https://codereview.appspot.com/97870044/

« Back to merge proposal