Merge lp:~hbrunn/banking-addons/lp-1106831-handle-P into lp:banking-addons/6.1

[Holger Brunn (Therp)]

Now replacing Ps by zeroes as proposed

[Stefan Rijnhart (Opener) (stefan-opener)]

Good catch, but did you check whether this makes for a valid Clieop file? The most recent Clieop specifications don't mention it, but the specifications from March 2006 rule it out explicitely in page 15 of

    http://www-old.adslweb.net/tools/clieop2psv/ClieOp_03_EN.pdf

It may be bank specific as well. Rabobank rules it out in page 12 of

    https://www.rabobank.com/en/images/Format_description__RCM6.pdf

So does ING in page 10 of

    http://www.ing.nl/Images/ClieOp_03_tcm7-69019.pdf

All of this seems to indicate that a better approach would be to replace the P by a zero. What do you think?

review: Needs Information

[Holger Brunn (Therp) (hbrunn)]

I think you are right. But to me the specification seems to tell to remove the P, not to replace it by a zero.
Unfortunately, I don't have access to any bank account to test that currently.

[Stefan Rijnhart (Opener) (stefan-opener)]

Numeric fields in the Clieop format, such as the account number are right justified and padded with leading zeroes[1]. The clieop export filter takes care of this, so whether you can remove the 'P' depends on whether it already has done that at that point. Replacing is probably your safest option.

[1] Page 15 of http://www.equens.com/Images/CLIEOP%20EN.pdf

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks!

review: Approve

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

i lack expertise in the field but the code looks ok to me.

=== modified file 'account_banking_nl_clieop/wizard/clieop.py'
--- account_banking_nl_clieop/wizard/clieop.py	2013-01-14 15:21:11 +0000
+++ account_banking_nl_clieop/wizard/clieop.py	2013-01-28 09:07:36 +0000
@@ -276,8 +276,8 @@
         self.paymentreference = Optional(PaymentReferenceRecord)
         self.description = Optional(DescriptionRecord, 4)
         self.transaction.transactiontype = type_
-        self.transaction.accountno_beneficiary = accountno_beneficiary
-        self.transaction.accountno_payer = accountno_payer
+        self.transaction.accountno_beneficiary = accountno_beneficiary.replace('P', '0')
+        self.transaction.accountno_payer = accountno_payer.replace('P', '0')
         self.transaction.amount = int(round(amount * 100))
         if reference:
             self.paymentreference.paymentreference = reference