Merge lp:~hazmat/txzookeeper/errors-with-path into lp:txzookeeper
Proposed by
Kapil Thangavelu
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jim Baker | ||||
Approved revision: | 44 | ||||
Merged at revision: | 50 | ||||
Proposed branch: | lp:~hazmat/txzookeeper/errors-with-path | ||||
Merge into: | lp:txzookeeper | ||||
Diff against target: |
160 lines (+20/-18) 1 file modified
txzookeeper/client.py (+20/-18) |
||||
To merge this branch: | bzr merge lp:~hazmat/txzookeeper/errors-with-path | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jim Baker (community) | Approve | ||
Gustavo Niemeyer | Approve | ||
Review via email: mp+77254@code.launchpad.net |
Description of the change
Errors should include path information.
Its very helpful when debugging zk error messages to know what the actual path
that caused the error was.
To post a comment you must log in.
<niemeyer> hazmat: Very nice
<niemeyer> hazmat: I suggest adding a colon here:
<niemeyer> + error_msg += " %s" % path
<niemeyer> error_msg += ": %s" % path
<niemeyer> hazmat: +1 either way