Code review comment for lp:~hazmat/pyjuju/states-with-principals

Revision history for this message
Kapil Thangavelu (hazmat) wrote :

Reviewers: mp+100783_code.launchpad.net,

Message:
Please take a look.

Description:
Security integration with state package.

Provides for principals created when corrresponding states are
created that have agents associated.

https://code.launchpad.net/~hazmat/juju/states-with-principals/+merge/100783

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/5966076/

Affected files:
   A [revision details]
   M juju/agents/tests/common.py
   M juju/lib/testing.py
   M juju/providers/local/__init__.py
   M juju/providers/local/tests/test_provider.py
   M juju/state/base.py
   M juju/state/initialize.py
   M juju/state/machine.py
   M juju/state/relation.py
   M juju/state/security.py
   A juju/state/securityrules.py
   M juju/state/service.py
   M juju/state/tests/common.py
   M juju/state/tests/test_agent.py
   M juju/state/tests/test_base.py
   M juju/state/tests/test_errors.py
   M juju/state/tests/test_initialize.py
   M juju/state/tests/test_machine.py
   M juju/state/tests/test_relation.py
   M juju/state/tests/test_security.py
   M juju/state/tests/test_service.py
   M juju/unit/lifecycle.py

« Back to merge proposal