Merge lp:~hazmat/pyjuju/security-groups into lp:pyjuju

[Kapil Thangavelu]

Implements a security group as a stored/persistent principal with membership denoting acl access to utilize the group principal credentials on a connection.

Resubmitting because this is not showing up the kanban board.

[Gustavo Niemeyer (niemeyer)]

This looks good. Some minors, and +1.

(note it includes a pre-req branch still in review)

[1]

+ @inlineCallbacks
+ def initialize(self):
+ """Initialize the group.

Would be nice to have that right after __init__.

[2]

+ if self._name is None:
+ raise ValueError("initialize() must be called before usage")

This should be a RuntimeError or similar.

[3]

+ raise StateNotFound("group does not exist at %r" % self._path)

s/group/Group/

[4]

+ raise ValueError(
+ "Principal: %r is already a member of group: %r" % (
(...)
+ if not found:
+ raise ValueError("Principal: %r is not a member of group: %r" % (

As I understand it, this logic is going to be used by code, and the final
state that we get into is the desired one, so it feels like both of these
could just be NOOPs. Even more considering there are race conditions into
play here.

[5]

+ acl.append(
+ make_ace(token, read=True))

This fits in a line.

review: Approve

[William Reade (fwereade)]

+1 to everything niemeyer said :).

review: Approve

[lp:~hazmat/pyjuju/security-groups]

289. By Kapil Thangavelu on 2011-07-26

Merged security-connection into security-groups.

290. By Kapil Thangavelu on 2011-08-04

Merged security-connection into security-groups.

291. By Kapil Thangavelu on 2011-08-04

Merged security-connection into security-groups.

292. By Kapil Thangavelu on 2011-08-05

resolve conflict from security-connection merge.

293. By Kapil Thangavelu on 2011-08-05

Merged trunk-merge into security-groups.

294. By Kapil Thangavelu on 2011-08-05

address review comments, conflicts are silent (same goal state reached), duplicate state creation errors are runtime-exceptions.