Merge lp:~hazmat/pyjuju/local-provider-config into lp:pyjuju

Proposed by Kapil Thangavelu
Status: Merged
Approved by: Gustavo Niemeyer
Approved revision: 389
Merged at revision: 363
Proposed branch: lp:~hazmat/pyjuju/local-provider-config
Merge into: lp:pyjuju
Prerequisite: lp:~hazmat/pyjuju/provider-determines-placement
Diff against target: 0 lines
To merge this branch: bzr merge lp:~hazmat/pyjuju/local-provider-config
Reviewer Review Type Date Requested Status
Gustavo Niemeyer Approve
Review via email: mp+76330@code.launchpad.net

Description of the change

Enable configuring/using local provider via environment

Local/lxc provider should be useable through environments.yaml configuration. At
a miniumum this means

  laptop:
     provider: lxc
     admin-secret: magic
     data-dir: /tmp/local-dev

To post a comment you must log in.
388. By Kapil Thangavelu

Merged provider-determines-placement into local-provider-config.

389. By Kapil Thangavelu

Merged provider-determines-placement into local-provider-config.

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

LGTM, with a few details:

[1]

> provider: lxc

It feels like a bad idea to be naming the local provider as "lxc", in hindsight. It conflates
two different concepts: deployment of units in lxc, that can happen in any provider type,
with the use of the local machine for development purposes, which is what this setting is
really about.

Can we please rename the provider itself to "local" on a follow up branch once all
the in-progress work is merged (to avoid having to deal with conflicts)?

[2]

27 +ensemble: environments
28 +

All yaml headers were dropped. Please kill this before merging.

[3]

66 def __init__(self):
67 - self.instance_id = "local"
68 - self.private_dns_name = self.dns_name = "localhost"
69 + pass

I'd prefer to use the constructor of the base class instead, as
this will hook up both implementations and we'll get to know
about divergences:

super(LocalMachine, self).__init__("local", private_dns_name="localhost")

review: Approve
390. By Kapil Thangavelu

Merged provider-determines-placement into local-provider-config.

391. By Kapil Thangavelu

Merged provider-determines-placement into local-provider-config.

392. By Kapil Thangavelu

Merged provider-determines-placement into local-provider-config.

393. By Kapil Thangavelu

Merged provider-determines-placement into local-provider-config.

394. By Kapil Thangavelu

merge trunk and resolve conflict

395. By Kapil Thangavelu

Merged provider-determines-placement into local-provider-config.

396. By Kapil Thangavelu

data-dir is required for local provider, drop storage-dir param

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to status/vote changes: